This repository was archived by the owner on Apr 30, 2020. It is now read-only.
Admin UI for events #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Jammed delete and edit into the same UI as creating events * TODO: Clean this all up, make it inline, more sane handling of data
nyaculak
suggested changes
Apr 28, 2019
Member
nyaculak
left a comment
nyaculak
left a comment
There was a problem hiding this comment.
Looks good. Ready to merge after dealing with the TODO's.
| import { Form } from 'semantic-ui-react' | ||
|
|
||
| class EventCreate extends React.Component { | ||
| state = {id: 0, title: '', description: '', startEpoch: 0, endEpoch: 0, location: '', beginner: false, tags: ''} |
Member
There was a problem hiding this comment.
Might be nice to extract this out of the class level as const DEFAULT_STATE = ... then state = DEFAULT_STATE inside the class level
| constructor (props) { | ||
| super(props); | ||
|
|
||
| if(this.props.edit) { |
| event.img = "http://semantic-ui.com/images/wireframe/image.png"; | ||
| } | ||
|
|
||
| let labels = []; |
Member
There was a problem hiding this comment.
You can replace this logic with a call to Array.prototype.map. Also, every React element in a list should have a unique key prop.
Also thinking that category should be renamed categories.
| labels.push(<Label>{cat}</Label>) | ||
| } | ||
|
|
||
| const st = (new Date(event.startTime)).toLocaleTimeString('en-US', {hour: '2-digit', minute:'2-digit'}) |
Member
There was a problem hiding this comment.
Just name these startTime and endTime for readability purposes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some TODOs:
imgfield