Skip to content

"IsInstalled is true for x86 when only x64 is installed" issue fixed #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hakanboluk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

"IsInstalled is true for x86 when only x64 is installed" issue fixed #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions RedistributableChecker/RedistributablePackage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,21 +45,23 @@ public static bool IsInstalled(RedistributablePackageVersion redistributableVers
switch (redistributableVersion)
{
case RedistributablePackageVersion.VC2015to2019x86:
var parametersVc2015to2019x86 = Registry.LocalMachine.OpenSubKey(@"SOFTWARE\Microsoft\DevDiv\VC\Servicing\14.0\RuntimeMinimum", false);
if (parametersVc2015to2019x86 == null) return false;
var vc2015to2019x86Version = parametersVc2015to2019x86.GetValue("Version");
if (((string)vc2015to2019x86Version).StartsWith("14"))
String keyNameStart = "VC,redist.x86,x86";
RegistryKey dependencies = Registry.ClassesRoot.OpenSubKey(@"Installer\Dependencies", false);
if (dependencies == null) return false;
foreach (String subKeyName in dependencies.GetSubKeyNames())
{
return true;
if (subKeyName.StartsWith(keyNameStart))
return true;
}
break;
case RedistributablePackageVersion.VC2015to2019x64:
var parametersVc2015to2019x64 = Registry.LocalMachine.OpenSubKey(@"SOFTWARE\Microsoft\DevDiv\VC\Servicing\14.0\RuntimeMinimum", false);
if (parametersVc2015to2019x64 == null) return false;
var vc2015to2019x64Version = parametersVc2015to2019x64.GetValue("Version");
if (((string)vc2015to2019x64Version).StartsWith("14"))
keyNameStart = "VC,redist.x64,amd64";
dependencies = Registry.ClassesRoot.OpenSubKey(@"Installer\Dependencies", false);
if (dependencies == null) return false;
foreach (String subKeyName in dependencies.GetSubKeyNames())
{
return true;
if (subKeyName.StartsWith(keyNameStart))
return true;
}
break;
case RedistributablePackageVersion.VC2017x86:
Expand Down