Draft
Conversation
jdamp-bis
force-pushed
the
pipeline-publish
branch
from
101530f to
bc4f013
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+45
to
+62
| runs-on: ubuntu-latest | ||
| needs: build | ||
| if: ${{ success() && github.ref == 'refs/heads/main' && github.event_name == 'push' }} | ||
| steps: | ||
| - name: Download quarto-docs artifact | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: quarto-docs | ||
| path: docs | ||
|
|
||
| - name: Upload pages artifact | ||
| id: deployment | ||
| uses: actions/upload-pages-artifact@v3 | ||
| with: | ||
| path: docs | ||
|
|
||
| - name: Deploy to GitHub Pages | ||
| uses: actions/deploy-pages@v4 |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Comment on lines
+9
to
+32
| name: Release | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.12" | ||
|
|
||
| - name: Install dependencies | ||
| run: pip install twine | ||
|
|
||
| - name: Build | ||
| run: python .\setup.py sdist bdist_wheel | ||
|
|
||
| - name: Check | ||
| run: python -m twine check dist/* | ||
|
|
||
| - name: Publish | ||
| env: | ||
| TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }} | ||
| TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }} | ||
| run: twine upload dist/* |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Contributor
|
@jdamp-bis I think it would be a good idea to follow GitHub's suggestion and add permissions to the job: https://github.com/bis-med-it/gingado/security/code-scanning/4. Could you please implement it when you have some time? |
- fix: syntax issue in bash statement - fix: add missing workflow permissions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces two pipeline jobs to publish the documentation to GitHub pages and a package version to pypi.
Open points:
Other notes:
This would require setting the new version as part of the PR, as it needs to be available when the package is build in the pipeline after the PR is merged.
Potentially, we can also make the publish-release step a manual one, requiring explicit start.