Skip to content

Conversation

@alxvth
Copy link
Contributor

@alxvth alxvth commented Apr 25, 2024

  • Use size_t for container size
  • Use std::uint64_t and std::int64_t instead of unsigned int and int to prevent overflows
  • Add template parameters typename unsigned_integer and typename integer to most classes in order to use 32 bit ints if desired
  • Harmonize knn search in HierarchicalSNE and HDJointProbabilityGenerator
  • Increase version since
    • consumers of this library now need to specify some types like hdi::dr::GradientDescentTSNETexture<float> instead of hdi::dr::GradientDescentTSNETexture, see update example
    • the cpp version changes to 17 from 14

Fixes #28.

@alxvth alxvth marked this pull request as draft April 25, 2024 20:13
@alxvth alxvth marked this pull request as ready for review April 26, 2024 07:36
@alxvth alxvth requested a review from bldrvnlw April 26, 2024 07:42
@alxvth alxvth marked this pull request as draft April 26, 2024 11:22
@alxvth alxvth force-pushed the feature/LargerDataSizes branch from 9f28452 to 7957069 Compare May 23, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Int overflow in void HierarchicalSNE<scalar_type, sparse_scalar_matrix_type>::initializeFirstScale() for large data

2 participants