Skip to content

Conversation

@Marukome0743
Copy link

Summary

The javascript.formatter.trailingComma option is deprecated and renamed to javascript.formatter.trailingCommas.
Then add the configuration.

Details can be checked in biomejs/biome#2492

@netlify
Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit f5c83a7
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/666277b293dcba0008da29aa
😎 Deploy Preview https://deploy-preview-527--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Sec-ant Sec-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think we should also mark trailingComma as deprecated or remove it. Do you want to help?

There're other deprecated options that possibly should also be taken care of, like indentSize and command line options like --trailing-comma in the CLI doc page.

@Marukome0743
Copy link
Author

Thank you, I think we should also mark trailingComma as deprecated or remove it. Do you want to help?

Yup, I wanna add the warning to old options.

Warning

javascript.formatter.trailingComma is deprecated.
Use javascript.formatter.trailingCommas instead.

Or folding the old options like the below.

javascript.formatter.trailingComma (deprecated)

Print trailing commas wherever possible in multi-line comma-separated syntactic structures. Possible values:

  • "all", the trailing comma is always added;
  • "es5", the trailing comma is added only in places where it’s supported by older version of JavaScript;
  • "none", trailing commas are never added.
    Default: "all"

There're other deprecated options that possibly should also be taken care of, like indentSize and command line options like --trailing-comma in the CLI doc page.

I'm willing to update the docs in order to adapt version 1.8.0.
However, I wonder my changes will be overriden when #518 merged.

This PR might be just temporary update until #518.

@Sec-ant
Copy link
Contributor

Sec-ant commented Jun 7, 2024

Fair, let's merge this first.

@Sec-ant Sec-ant merged commit f4a3ba1 into biomejs:main Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants