-
Notifications
You must be signed in to change notification settings - Fork 31
Katherine Soderberg's project outline #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Sounds good. Try to break what you want to do into smaller chunks so that you can check them off as you go. It also means that at the end if you've only ticked off the first stepping stone you have a working program. Then rinse and repeat. Agreed about needing more python to know what you can and can't do. ask questions on the Gitter channel for pointers too. |
|
Pasting update here for posterity: |
|
Do you need any help? Are you struggling to push updates to GitHub or debugging things for now? |
|
Hello, do you need help with anything at this point? You can post questions here or bring questions to the class today. |
|
Thank you for checking in! I will update Github before this evening and
bring debugging questions to class!
…On Thu, May 7, 2020 at 12:21 PM Suhwan Paul Lee ***@***.***> wrote:
Hello, do you need help with anything at this point? You can post
questions here or bring questions to the class today.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKDUJXIZRWNAD2SMKEL7VBDRQLN2BANCNFSM4K5GUUMA>
.
|
|
Well done on passing the tests. Always a cause for celebration! |
|
Nicely implemented project. Overall it achieves something useful in a clean modular, reusable way. Obviously the tests could be more extensive. Getting them working full stop is great so well done for persevering with that but I encourage you to check out some of the other project to get a sense of the sorts of ways you can go about testing. In the long term, including tests as you develop code will make life much easier. Some other minor points: Your attention to python style was very good. There were a couple of time you slipped. Keep the style guide pep8 in mind. Revisiting it periodically allows you to constantly improve your style which will help others to interpret your code (and you will be able to quickly interpret the code of others inclined towards attention to such important details). In general imports should occur at the top of a file. It prevents various annoying issues and makes your dependencies apparent to anyone with a quick glance at the top of a python module. Also, adding comments within the code itself is a good idea. This is a nice guide. Code that is very obvious at the time of writing becomes a lot less clear to you a few months later. Be kind to future Katherine. |
No description provided.