Skip to content
This repository was archived by the owner on Nov 9, 2023. It is now read-only.

Comments

Hdf5 handler#244

Open
wasade wants to merge 8 commits intobiocore:masterfrom
wasade:hdf5_handler
Open

Hdf5 handler#244
wasade wants to merge 8 commits intobiocore:masterfrom
wasade:hdf5_handler

Conversation

@wasade
Copy link
Member

@wasade wasade commented Dec 22, 2013

Added support so we can automatically and implicitly resize hdf5 datasets. This is in support of the pending updates to the split libraries workflow

@wasade
Copy link
Member Author

wasade commented Mar 19, 2014

retest this please

@jairideout
Copy link
Member

Travis doesn't listen to retest comments unfortunately. To have this retested, click "Details" and hit the refresh button that's towards the top right of the screen.

@wasade
Copy link
Member Author

wasade commented Mar 19, 2014

ahh, thanks

@wasade
Copy link
Member Author

wasade commented Mar 19, 2014

there isn't a refresh there

@wasade
Copy link
Member Author

wasade commented Mar 19, 2014

@ElBrogrammer, travis is confused over the repo name change. this is a low prio pull right now as we don't yet have any hdf5 code in use though, just trying to clean out PRs

@jairideout
Copy link
Member

probably b/c pyqi was moved from the bipy org to biocore

@jairideout
Copy link
Member

Found the new link to this PR on Travis. I went ahead and restarted the tests:

https://travis-ci.org/biocore/pyqi/builds/15857676

@wasade
Copy link
Member Author

wasade commented Mar 19, 2014

Thanks. One failure, which isn't surprising as HDF5 should be considered an
optional dependency here. Do you know how to get nosetests to not execute
tests if an optional dependency is missing?

On Wed, Mar 19, 2014 at 11:34 AM, Jai Ram Rideout
notifications@github.comwrote:

Found the new link to this PR on Travis. I went ahead and restarted the
tests:

https://travis-ci.org/biocore/pyqi/builds/15857676

Reply to this email directly or view it on GitHubhttps://github.com//pull/244#issuecomment-38082313
.

@jairideout
Copy link
Member

Not sure for nose, but you might add conditional unit tests that are skipped if h5py isn't present:

http://docs.python.org/3.1/library/unittest.html#skipping-tests-and-expected-failures

@wasade
Copy link
Member Author

wasade commented Mar 19, 2014

this PR got really weird conflicts that ive never seen before. right now, through mechanisms i don't understand, this PR is now blocked by py33

@jairideout
Copy link
Member

Want to close this one and reissue?

@wasade
Copy link
Member Author

wasade commented Mar 19, 2014

suspect it'll be fine once py33 is merged

we really need to avoid long outstanding PRs, though i know it is difficult
to get some of these merged at times and to get effort on them

On Wed, Mar 19, 2014 at 12:22 PM, Jai Ram Rideout
notifications@github.comwrote:

Want to close this one and reissue?

Reply to this email directly or view it on GitHubhttps://github.com//pull/244#issuecomment-38088056
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants