Skip to content

Conversation

@MSiggel
Copy link
Contributor

@MSiggel MSiggel commented Oct 21, 2018

Initial support for lammps simulations.
lammps module added, parsing added and test files added.

PR Checklist

  • Added changelog fragment in ./changelog/ (more information)?
  • Issue raised/referenced?

@MSiggel MSiggel requested a review from mimischi October 21, 2018 09:44
@MSiggel
Copy link
Contributor Author

MSiggel commented Oct 21, 2018

I added most of the stuff to use the code with LAMMPS in a crude manner. Same as in namd an issue here is that multiple files are required to run a simulation. Similiar issue will be the case when using AMBER. In light of this we should also discuss in this PR how we handle files which have to be provided i.e. whether we just assume that the user has to provide all files with the same name or not.
This would decrease reliability for those engines because the user might make mistakes.

Copy link
Contributor

@mimischi mimischi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any log files so we can test the file parsers?

continue

path = line.split()[1]
if "$" in path:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all NAMD specific.

LAMMPS_WARNING = (
"LAMMPS support is experimental."
"All input files must be in the same directory and have the same base name!"
"We hope you know what you're doing..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"We hope you know what you're doing..."

# vim: tabstop=4 expandtab shiftwidth=4 softtabstop=4 fileencoding=utf-8
#
# MDBenchmark
# Copyright (c) 2017 Max Linke & Michael Gecht and contributors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright (c) 2017 Max Linke & Michael Gecht and contributors
# Copyright (c) 2017-2018 The MDBenchmark development team and contributors

@MSiggel
Copy link
Contributor Author

MSiggel commented Oct 21, 2018

I added the analyze-files-lammps folder. There is a sample log file in folder /1.
I'll have to rerun this simulation the cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants