Change srl_generator_v5.js to support different sizes#5
Open
savage13 wants to merge 1 commit intobingothon:masterfrom
Open
Change srl_generator_v5.js to support different sizes#5savage13 wants to merge 1 commit intobingothon:masterfrom
savage13 wants to merge 1 commit intobingothon:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change srl_generator_v5.js to support different sizes.
Bingo board size of 5 is still the default.
The primary mnodification here is the construction of the
lineCheckListvariable. This is now done through themakeCheckListfunction. Diagonals are only used in odd-sized tables.This was checked for a board size of 5 for the Normal Zelda BotW bingo for the first 1,000,000 seeds; max seed is 999,999 but it is never checked.
More tests were done that confirms the time to complete a row, column or diagonal increased with increases with board size. Plots of this data are in the botw-bingosync-dev discord channel.