Agregando env de credenciales de dockerhub#3
Merged
christopherBinaural merged 1 commit intoreleasefrom Nov 24, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Este PR agrega las credenciales de Docker Hub como variables de entorno al workflow de GitHub Actions. El cambio renombra las variables de entorno de Docker registry de ORG_DOCKER_REGISTRY_* a DOCKER_REGISTRY_*, siguiendo el mismo patrón de nomenclatura usado para las variables S3 en el mismo workflow.
- Renombra tres variables de entorno de Docker registry para seguir el patrón de nomenclatura consistente
- Los secretos de GitHub mantienen el prefijo
ORG_mientras que las variables de entorno pasadas a la acción usan nombres simplificados - Permite que el action
mount-cicd-tooltenga acceso a las credenciales del registro de Docker
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+103
to
+105
| DOCKER_REGISTRY_URL: ${{ secrets.ORG_DOCKER_REGISTRY_URL }} | ||
| DOCKER_REGISTRY_USERNAME: ${{ secrets.ORG_DOCKER_REGISTRY_USERNAME }} | ||
| DOCKER_REGISTRY_PASSWORD: ${{ secrets.ORG_DOCKER_REGISTRY_PASSWORD }} |
There was a problem hiding this comment.
La documentación al inicio del archivo debe actualizarse para incluir los secretos de Docker registry que ahora se están utilizando. Agregar:
- ORG_DOCKER_REGISTRY_URL
- ORG_DOCKER_REGISTRY_USERNAME
- ORG_DOCKER_REGISTRY_PASSWORD
a la sección de secretos requeridos (líneas 3-10).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.