Skip to content

Agregando env de credenciales de dockerhub #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherBinaural merged 1 commit into from
Nov 24, 2025
Merged

Agregando env de credenciales de dockerhub #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/check-pr-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,9 @@ jobs:
S3_BUCKET_NAME: ${{ secrets.ORG_S3_BUCKET_NAME }}
S3_ENDPOINT_URL: ${{ secrets.ORG_S3_ENDPOINT_URL }}
S3_REGION_NAME: ${{ secrets.ORG_S3_REGION_NAME }}
ORG_DOCKER_REGISTRY_URL: ${{ secrets.ORG_DOCKER_REGISTRY_URL }}
ORG_DOCKER_REGISTRY_USERNAME: ${{ secrets.ORG_DOCKER_REGISTRY_USERNAME }}
ORG_DOCKER_REGISTRY_PASSWORD: ${{ secrets.ORG_DOCKER_REGISTRY_PASSWORD }}
Comment on lines +103 to +105
Copy link

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Las nuevas credenciales de Docker deberían añadirse a la documentación de secretos requeridos en el encabezado del archivo. El comentario en las líneas 3-10 lista todos los secretos necesarios, y los tres nuevos secretos de Docker Registry (ORG_DOCKER_REGISTRY_URL, ORG_DOCKER_REGISTRY_USERNAME, ORG_DOCKER_REGISTRY_PASSWORD) deberían incluirse ahí para mantener la documentación actualizada.

Copilot uses AI. Check for mistakes.
Comment on lines +103 to +105
Copy link

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Las nuevas credenciales de Docker Registry no tienen validaciones correspondientes en el paso "Validar configuración requerida". Similar a las validaciones existentes para S3 (líneas 85-89), deberían añadirse validaciones para verificar que ORG_DOCKER_REGISTRY_URL, ORG_DOCKER_REGISTRY_USERNAME y ORG_DOCKER_REGISTRY_PASSWORD no estén vacías antes de ejecutar el workflow, para que fallen rápidamente con mensajes de error claros si faltan.

Copilot uses AI. Check for mistakes.
with:
CICD_TOKEN: ${{ secrets.ORG_CICD_TOKEN }}
cli-command: |
Expand Down