Skip to content

fix: treat HTTP 202 Accepted as valid response #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nats merged 1 commit into from
Jan 21, 2026
Merged

fix: treat HTTP 202 Accepted as valid response #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/binarylane/console/runners/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,9 @@ def response(self, status_code: int, received: Any) -> None:
if status_code == 401:
self.error(ExitCode.TOKEN, 'Unable to authenticate with API - please run "bl configure" to get started.')

# If no response is available, report an API error (unless it is `204 No Content`)
# If no response is available, report an API error (unless it is `202 Accepted` or `204 No Content`)
if received is None:
if status_code != 204:
if status_code not in (202, 204):
self.error(ExitCode.API, f"HTTP {status_code}")
return

Expand Down
10 changes: 10 additions & 0 deletions tests/runners/test_command_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,16 @@ def test_response_handles_nocontent(capsys: CaptureFixture[str]) -> None:
assert captured.err == "" and captured.out == ""


def test_response_handles_accepted(capsys: CaptureFixture[str]) -> None:
"""HTTP 202 Accepted with no body should not be treated as an error."""
runner = TypeRunner(CommandRunner)

runner.test.response(202, None)

captured = capsys.readouterr()
assert captured.err == "" and captured.out == ""


def test_response_handles_ok(capsys: CaptureFixture[str]) -> None:
runner = TypeRunner(CommandRunner)

Expand Down
Loading