add a handful of features and some testing #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williballenthin
force-pushed
the
idalib-rs-capa-features
branch
2 times, most recently
from
155747a to
32b8b8f
Compare
williballenthin
force-pushed
the
idalib-rs-capa-features
branch
from
32b8b8f to
fd88c74
Compare
williballenthin
force-pushed
the
idalib-rs-capa-features
branch
from
fd88c74 to
1019108
Compare
williballenthin
force-pushed
the
idalib-rs-capa-features
branch
from
ff72393 to
ea48de4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a handful of features that are useful for porting capa to Rust (local experiment).
Perhaps more interestingly, it proposes a testing mechanism. I found that using the default test harness didn't work with idalib-rs, because IDA has to be used from the main thread, and the test harness spawns tests on worker threads. But, with custom test binaries, we can still develop and run tests, with just a bit more effort. Let me know what you think.