fix(auth): auto-submit filled keyboard-interactive prompts#214
fix(auth): auto-submit filled keyboard-interactive prompts#214RoryChou-flux wants to merge 2 commits intobinaricat:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b527355005
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| authMethods.push({ type: "keyboard-interactive", id: "keyboard-interactive" }); | ||
| authMethods.push({ type: "password", id: "password" }); |
There was a problem hiding this comment.
Keep password before keyboard-interactive for MFA handshakes
In buildAuthHandler's password-only dynamic branch, putting keyboard-interactive before password breaks ordered MFA flows when fallback options are present (for example, OpenSSH AuthenticationMethods password,keyboard-interactive). The auth loop marks each method as attempted before checking methodsLeft, so an initial round with only password available consumes keyboard-interactive without sending it; after password succeeds with partial auth, the next round can no longer select keyboard-interactive and authentication fails.
Useful? React with 👍 / 👎.
Summary
Behavior Notes
Validation
npm run -s lint -- components/KeyboardInteractiveModal.tsxnode --check electron/bridges/sshAuthHelper.cjs