Skip to content

Quests | Change name variables #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oobjectt wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Quests | Change name variables #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/nitro/communication/messages/outgoing/quest/AcceptQuestMessageComposer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ export class AcceptQuestMessageComposer implements IMessageComposer<ConstructorP
{
private _data: ConstructorParameters<typeof AcceptQuestMessageComposer>;

constructor(k: number)
constructor(questId: number)
{
this._data = [k];
this._data = [questId];
}

public getMessageArray()
Expand Down
4 changes: 2 additions & 2 deletions src/nitro/communication/messages/outgoing/quest/ActivateQuestMessageComposer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ export class ActivateQuestMessageComposer implements IMessageComposer<Constructo
{
private _data: ConstructorParameters<typeof ActivateQuestMessageComposer>;

constructor(k: number)
constructor(questId: number)
{
this._data = [k];
this._data = [questId];
}

public getMessageArray()
Expand Down
4 changes: 2 additions & 2 deletions src/nitro/communication/messages/outgoing/quest/GetCommunityGoalHallOfFameMessageComposer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ export class GetCommunityGoalHallOfFameMessageComposer implements IMessageCompos
{
private _data: ConstructorParameters<typeof GetCommunityGoalHallOfFameMessageComposer>;

constructor(k: string)
constructor(code: string)
{
this._data = [k];
this._data = [code];
}

public getMessageArray()
Expand Down
4 changes: 2 additions & 2 deletions src/nitro/communication/messages/outgoing/quest/GetDailyQuestMessageComposer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ export class GetDailyQuestMessageComposer implements IMessageComposer<Constructo
{
private _data: ConstructorParameters<typeof GetDailyQuestMessageComposer>;

constructor(k: boolean, _arg_2: number)
constructor(canRefresh: boolean, index: number)
{
this._data = [k, _arg_2];
this._data = [canRefresh, index];
}

public getMessageArray()
Expand Down
4 changes: 2 additions & 2 deletions src/nitro/communication/messages/outgoing/quest/StartCampaignMessageComposer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ export class StartCampaignMessageComposer implements IMessageComposer<Constructo
{
private _data: ConstructorParameters<typeof StartCampaignMessageComposer>;

constructor(k: string)
constructor(campaignName: string)
{
this._data = [k];
this._data = [campaignName];
}

public getMessageArray()
Expand Down
14 changes: 7 additions & 7 deletions src/nitro/communication/messages/parser/quest/PrizeData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ export class PrizeData
private _badge: boolean;
private _localizedName: string;

constructor(k: IMessageDataWrapper)
constructor(wrapper: IMessageDataWrapper)
{
this._communityGoalId = k.readInt();
this._communityGoalCode = k.readString();
this._userRank = k.readInt();
this._rewardCode = k.readString();
this._badge = k.readBoolean();
this._localizedName = k.readString();
this._communityGoalId = wrapper.readInt();
this._communityGoalCode = wrapper.readString();
this._userRank = wrapper.readInt();
this._rewardCode = wrapper.readString();
this._badge = wrapper.readBoolean();
this._localizedName = wrapper.readString();
}

public get communityGoalId(): number
Expand Down
16 changes: 8 additions & 8 deletions src/nitro/communication/messages/parser/quest/QuestMessageData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ export class QuestMessageData
this._easy = wrapper.readBoolean();
}

public static getCampaignLocalizationKeyForCode(k: string): string
public static getCampaignLocalizationKeyForCode(code: string): string
{
return 'quests.' + k;
return 'quests.' + code;
}

public get campaignCode(): string
Expand Down Expand Up @@ -72,19 +72,19 @@ export class QuestMessageData
return this._activityPointType;
}

public set accepted(k: boolean)
public set accepted(isAccepted: boolean)
{
this._accepted = k;
this._accepted = isAccepted;
}

public get accepted(): boolean
{
return this._accepted;
}

public set id(k: number)
public set id(id: number)
{
this._id = k;
this._id = id;
}

public get id(): number
Expand Down Expand Up @@ -122,9 +122,9 @@ export class QuestMessageData
return this._completedSteps == this._totalSteps;
}

public set waitPeriodSeconds(k: number)
public set waitPeriodSeconds(periodSeconds: number)
{
this._waitPeriodSeconds = k;
this._waitPeriodSeconds = periodSeconds;
}

public get waitPeriodSeconds(): number
Expand Down