Convert ember-date-picker into Ember-cli Addon#4
Open
DanielOchoa wants to merge 10 commits intobilldami:masterfrom
Open
Convert ember-date-picker into Ember-cli Addon#4DanielOchoa wants to merge 10 commits intobilldami:masterfrom
DanielOchoa wants to merge 10 commits intobilldami:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there!
I really like your component. I was working in a project that needed this then I realized this component would no longer work in the current version of Ember so I went ahead and refactored it into an Ember Addon for Ember Cli (Ember cli will become part of Ember eventually and is now the best way to build Ember Apps).
EDIT: You can test it by cloning this pull request and running
ember s.