DEV: make sure all priors return float when needed #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2025
Removed unused import of interp1d from scipy.interpolate.
mj-will
approved these changes
Aug 27, 2025
Collaborator
mj-will
left a comment
mj-will
left a comment
There was a problem hiding this comment.
LGTM. I don't like the logic for the joint priors but I think we can leave that for a different PR
mattpitkin
approved these changes
Aug 29, 2025
mj-will
pushed a commit
to mj-will/bilby
that referenced
this pull request
Oct 16, 2025
* DEV: make sure all priors return float when needed * FEAT: add fermi-dirac CDF * TST: add testing of fermi dirac and symmetric log uniform priors * FMT: remove extraneous whitespace * BUG: revert bad changes to equal comparisons * BUG: Fix syntax error in return statement * BUG: Fix list return * BUG: fix array type output for rescale * BUG: Fix missing parentheses in squeeze method call * BUG: fix flattening logic * BUG: stop using arr[np.where(cond)] * Address comments * BUG: fix scipy integrate imports * BUG: Remove unused import of interp1d Removed unused import of interp1d from scipy.interpolate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of #848 that has been migrated to my fork.
@mj-will @asb5468 this means some of your comments are lost, but I addressed them in the latest commits.