BUG: issue warning when prior sampling efficiency is below 1e-3. #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj-will
reviewed
Nov 7, 2024
Collaborator
|
This overlaps with #839 |
Collaborator
@AlexandreGoettel @ColmTalbot shall we try to get this in before #839 since that is now marked as a draft? |
mj-will
approved these changes
Jan 22, 2025
ColmTalbot
force-pushed
the
fix_prior_sampling_freezing
branch
from
40dd8f3 to
a09d22e
Compare
ColmTalbot
approved these changes
Jan 23, 2025
Collaborator
ColmTalbot
left a comment
ColmTalbot
left a comment
There was a problem hiding this comment.
I'm happy to get this change in.
mj-will
force-pushed
the
fix_prior_sampling_freezing
branch
from
a09d22e to
70f9882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #817