Skip to content

Conversation

@ColmTalbot
Copy link
Collaborator

This PR implements the proposed modification to the likelihood from https://iopscience.iop.org/article/10.1088/1361-6382/ae1ac7/meta.

The main new feature is adding a crop_duration to the InterferometerStrainData and some accompanying utility code.

I modified how the GravitationalWaveTransient and BasicGravitationalWaveTransient call the data. I did not have to change the reference likelihood tests, so there is good evidence that this doesn't impact the numerical values when not using the cropping.

I suspect there is a performance penalty due to repeatedly whitening the data. There should be a way to cache this calculation, it just requires some cleverness about when the time/frequency masks might have changed.

  • I'm not sure at this time how this should interact with accelerated likelihood, so I've left them alone.
  • I also haven't validated how this interacts with time/calibration marginalization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant