BUG: Fix GWSignalWaveformGenerator reconstruction in waveform posterior plots #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to plot some waveform reconstructions using
plot_interferometer_waveform_posteriorfor some eccentric PE runs using the newGWSignalWaveformGenerator, and I realized it is currently not working correctly.The reason is that the arguments required to instantiate
GWSignalWaveformGeneratorare not saved in the likelihood metadata, and are not passed to the waveform generator when it is instantiated inplot_interferometer_waveform_posteriorhere.A fix is to save and pass these extra arguments whenever the waveform generator is
GWSignalWaveformGenerator. I have added this via awaveform_generator_constructor_dict, inspired by thisbilby_pipemerge request. Let me know if you have any other preferences for handling this.