Change probability initialization to use np.ones_like #1028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior.sample()seems to always trigger the warning:when using a prior with keys, without Constraints, and requesting more than 1000 samples. E.g.:
(And for some parallel workflows keeps triggering the warning).
This seems to stem from
evaluate_constraints()which defaults to returning a single1when there aren't Constraints (instead of an array of ones), which is then used to count the number of valid samples (n_valid_samples), returning always 1, and thus triggering the warning once one asks for more than 1000 samples (if n_tested >= 1e3 and efficiency < 1e-3:incheck_efficiency()).The solution proposed here is to replace
evaluate_constraints()'s defaultprobto be an array of ones like the first values inout_samples.