Improve appearance of drill move scrollbar#46
Draft
vdye wants to merge 2 commits intobigredbands:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it is now, the drill scrollbar is fairly useless; with just a handful of ranks, it's an unreadable blob of blue and red. This pull request updates the
MoveScrollbarclass to use theMoveThumbnailclass to represent the drill thumbnail, which itself is updated to extendFieldView, similar to howPdfImagewas updated in #41.Before:
After:
TODO (need to make thumbnail alignment work properly)