Skip to content

[Flink][Feature]Support task run not by jni call but use velox loop #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KevinyhZou wants to merge 3 commits into
base: gluten
Choose a base branch
from
Open

[Flink][Feature]Support task run not by jni call but use velox loop #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb17acc
add metrics for gluten
KevinyhZou Jun 4, 2025
7276e81
support task get result not by jni
KevinyhZou Jun 4, 2025
b0166c3
remove useless changes
KevinyhZou Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions velox/experimental/stateful/StatefulTask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ void StatefulTask::initOperators() {

RowVectorPtr StatefulTask::next(int32_t& retCode) {
retCode = 0;
initOperators();
// initOperators();
Copy link
Member

@zhanglistar zhanglistar Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个注释的原因是？


// Run operators one by one. If an operator has output, run its downstream operators.
// If the last operator has output, return the output.
Expand Down Expand Up @@ -112,7 +112,8 @@ RowVectorPtr StatefulTask::next(int32_t& retCode) {
}
return nullptr;
} else {
break;
// break;
return nullptr;
Copy link
Member

@zhanglistar zhanglistar Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里直接return？

}
}

Expand Down