Skip to content

Refine StatefulPlanner.plan #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Refine StatefulPlanner.plan #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14820c7
update
lgbo-ustc Jan 28, 2026
b84604b
Initial plan
Copilot Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 10 additions & 23 deletions velox/experimental/stateful/StatefulPlanner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,18 @@
*/
#include "velox/core/PlanFragment.h"
#include "velox/exec/AssignUniqueId.h"
#include "velox/exec/CallbackSink.h"
#include "velox/exec/EnforceSingleRow.h"
#include "velox/exec/Exchange.h"
#include "velox/exec/Expand.h"
#include "velox/exec/FilterProject.h"
#include "velox/exec/GroupId.h"
#include "velox/exec/HashAggregation.h"
#include "velox/exec/HashBuild.h"
#include "velox/exec/HashProbe.h"
#include "velox/exec/IndexLookupJoin.h"
#include "velox/exec/Limit.h"
#include "velox/exec/MarkDistinct.h"
#include "velox/exec/Merge.h"
#include "velox/exec/MergeJoin.h"
#include "velox/exec/NestedLoopJoinBuild.h"
#include "velox/exec/NestedLoopJoinProbe.h"
#include "velox/exec/OrderBy.h"
#include "velox/exec/RoundRobinPartitionFunction.h"
#include "velox/exec/RowNumber.h"
#include "velox/exec/StreamingAggregation.h"
#include "velox/exec/TableScan.h"
Expand Down Expand Up @@ -80,8 +74,6 @@ StatefulOperatorPtr StatefulPlanner::plan(
return planner.transformStatefulOperators(planFragment.planNode);
}

#define CHECK_NODE_TYPE(TYPE, node) std::dynamic_pointer_cast<const TYPE>(node->node()) != nullptr

StatefulOperatorPtr StatefulPlanner::transformStatefulOperators(const core::PlanNodePtr& planNode) {
auto statefulNode = std::dynamic_pointer_cast<const StatefulPlanNode>(planNode);
VELOX_CHECK(statefulNode, "Not stateful node: {}", planNode->toString());
Expand Down Expand Up @@ -272,7 +264,6 @@ StatefulOperatorPtr StatefulPlanner::transformGroupWindowAggregationOperator(con
auto windowAggNode = std::dynamic_pointer_cast<const GroupWindowAggregationNode>(planNode.node());
VELOX_CHECK(windowAggNode, "Failed to cast to GroupWindowAggregationNode");

VELOX_MEM_LOG(ERROR)<< "transformGroupWindowAggregationOperator:" << planNode.toString();
auto op = transformOperator(windowAggNode->aggregation());

std::unique_ptr<KeySelector> keySelector =
Expand Down Expand Up @@ -343,6 +334,14 @@ StatefulOperatorPtr StatefulPlanner::transformGroupAggregationOperator(const Sta
std::move(targets));
}

StatefulOperatorPtr StatefulPlanner::transformGenericOperator(const StatefulPlanNode& planNode) {
std::vector<StatefulOperatorPtr> targets = transformStatefulOperators(planNode.targets());
std::unique_ptr<exec::Operator> op = transformOperator(planNode.node());
return std::make_unique<StatefulOperator>(
std::move(op),
std::move(targets));
}

std::unique_ptr<exec::Operator> StatefulPlanner::transformOperator(const core::PlanNodePtr& planNode) {
if (auto filterNode = std::dynamic_pointer_cast<const core::FilterNode>(planNode)) {
if (planNode->sources().size() == 1) {
Expand Down Expand Up @@ -456,21 +455,9 @@ std::unique_ptr<exec::Operator> StatefulPlanner::transformOperator(const core::P
topNNode->outputRankNumber(),
topNNode->cacheSize());
}
std::unique_ptr<exec::Operator> extended;
extended = exec::Operator::fromPlanNode(ctx_, nextOperatorId(), planNode);
if (!extended) {
VELOX_MEM_LOG(ERROR)<< "Failed to create operator for plan node:" << process::StackTrace().toString();
}
VELOX_CHECK(extended, "Unsupported plan node: {}", planNode->toString());
std::unique_ptr<exec::Operator> extended = exec::Operator::fromPlanNode(ctx_, nextOperatorId(), planNode);
VELOX_CHECK(extended, "Unsupported plan node: {}\n{}", planNode->toString(), process::StackTrace().toString());
return extended;
}

StatefulOperatorPtr StatefulPlanner::transformGenericOperator(const StatefulPlanNode& planNode) {
std::vector<StatefulOperatorPtr> targets = transformStatefulOperators(planNode.targets());
std::unique_ptr<exec::Operator> op = transformOperator(planNode.node());
return std::make_unique<StatefulOperator>(
std::move(op),
std::move(targets));
}

} // namespace facebook::velox::stateful