Skip to content

fix memory leak #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shuai-xu merged 1 commit into from
Oct 29, 2025
Merged

fix memory leak #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions velox/connectors/print/PrintSink.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,14 @@ std::unique_ptr<dwio::common::Writer> PrintSink::createWriter(
if (fs->exists(path)) {
fs->remove(path);
}
std::shared_ptr<io::IoStatistics> ioStats =
std::make_shared<io::IoStatistics>();
std::unique_ptr<dwio::common::FileSink> writeFileSink =
dwio::common::FileSink::create(
path,
{
.bufferWrite = false,
.pool = queryCtx_->memoryPool(),
.metricLogger = dwio::common::MetricsLog::voidLog(),
.stats = ioStats.get(),
.stats = &ioStats_,
});
auto writerFactory =
dwio::common::getWriterFactory(dwio::common::FileFormat::TEXT);
Expand Down
2 changes: 2 additions & 0 deletions velox/connectors/print/PrintSink.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ class PrintSink : public DataSink {

connector::DataSink::Stats stats() const override;

io::IoStatistics ioStats_;

private:
const RowTypePtr inputType_;
const RowTypePtr outputType_;
Expand Down