fix(storefront): STRF-12688 Update messageformat dependency #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmwiese
changed the title
jmwiese
force-pushed
the
STRF-12688
branch
5 times, most recently
from
5d8807f to
8b1abe1
Compare
jairo-bc
approved these changes
Dec 16, 2024
Contributor
|
🎉 This PR is included in version 5.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
The previous version of messageformat (which is quite old) uses underscore which has a security vulnerability
https://github.com/bigcommerce/storefront-renderer-2/security/dependabot/4
This updates to the closest version which doesnt not have underscore
How was it tested?
Tested locally
Before:
After:
cc @bigcommerce/storefront-team