add close method to explicitly free TagFiles#2
Open
Whoops wants to merge 1 commit intobickfordb:masterfrom
Open
add close method to explicitly free TagFiles#2Whoops wants to merge 1 commit intobickfordb:masterfrom
Whoops wants to merge 1 commit intobickfordb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a close method for tagfiles. Theres actually a couple reasons for this. One is simply to avoid leaking file handles in the event that the garbage collector doesn't free them up fast enough. I actually haven't been able to write a test case where this is a problem, but it's still good practice.
The other issue that I actually DID run afoul of, is it's currently easy to write code that, when compiled with
ghc -Oactually frees the TagFile before your done with it.Consider the following snippet which inserts code into a acid-state database:
When compiled with optimizations GHC actually realizes that tagFile is never used, and allows it to be GCed, the resulting error is:
adding an explicit
close $ fromJust tagFileto that example resolves it.