Open
Conversation
Signed-off-by: bharath-techie <bharath78910@gmail.com>
Signed-off-by: bharath-techie <bharath78910@gmail.com>
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
* Refactor CompositeEngine to use factory Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> * Introduce SegmentCollector Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> * Introduce SegmentCollector Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> * Introduce SegmentCollector Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> --------- Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
* Refactor CompositeEngine to use factory Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> * Introduce SegmentCollector Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> * Introduce SegmentCollector Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> * Introduce SegmentCollector Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> * De-couple and simplify index file deleter Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> * De-couple and simplify index file deleter Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> * De-couple and simplify index file deleter, handle scorer and weight query lifecycle Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> * De-couple and simplify index file deleter, handle scorer and weight query lifecycle Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> * De-couple and simplify index file deleter, handle scorer and weight query lifecycle Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> --------- Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Signed-off-by: bharath-techie <bharath78910@gmail.com>
- Re-name SPI contract to ReaderManagerProvider to load in DataFormatAwareEngineFactory. - Deletes EngineBridge - replace with SearchExecEngine - add delegation framework api - sketch with just filter for now - removes non reader functionality from DataFormatAwareEngineFactory/Engine. Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
mch2
force-pushed
the
feature/delegation
branch
from
46e2002 to
a583373
Compare
| int numDocs = maxDocId - minDocId; | ||
| BitSet bitset = new BitSet(numDocs); | ||
|
|
||
| Scorer scorer = context.getWeight().scorer(leaf); |
Owner
There was a problem hiding this comment.
We are scoring for each call for each row group though, can't we model the delegates with same APIs as index filter provider / context.
| if (requestContext.hasDelegation()) { | ||
| DelegationContext delegation = requestContext.getDelegationContext(); | ||
| substraitBytes = SubstraitConverter.embedDelegation( | ||
| substraitBytes, delegation.getId(), null, "lucene-analytics-backend"); |
Owner
There was a problem hiding this comment.
Isn't "lucene-analytics-backend" leaking in datafusion ?
| this.datafusionQuery = query; | ||
| } | ||
|
|
||
| public IndexFilterTree getFilterTree() { |
Owner
There was a problem hiding this comment.
This will be still needed for boolean queries.
3 tasks
bharath-techie
force-pushed
the
native-eng
branch
6 times, most recently
from
91c83d5 to
17d7546
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.