[#237] Move file path derivation into SyncStrategy#245
Merged
Conversation
- Add `fileRelativePath(destination:fileType:)` to SyncStrategy protocol - Implement in GlobalSyncStrategy and ProjectSyncStrategy with scope-specific path logic - Remove `deriveFileRelativePath` from Configurator, eliminating isGlobalScope branch
…Path - Replace manual baseDirectory + appendingPathComponent with CopyFileType.destinationURL(in:destination:)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Configurator.deriveFileRelativePath()duplicated path-derivation logic that already existed inGlobalSyncStrategy.installArtifacts()andComponentExecutor.installProjectFile(). This broke the strategy pattern by introducing anisGlobalScopebranch in scope-agnostic code.Changes
fileRelativePath(destination:fileType:)protocol method toSyncStrategyGlobalSyncStrategy(relative to~/.claude/) andProjectSyncStrategy(relative to project root)GlobalSyncStrategy.installArtifactsto use the new method instead of inlining path logicConfigurator.deriveFileRelativePath, replacing it withstrategy.fileRelativePath(...)Testing
swift buildpassesswift test— all 711 tests pass (4 pre-existingPackFetcherTestsfailures from 1Password SSH agent, unrelated)Closes #237