[#236] Extract shared artifact-removal helpers#243
Merged
Conversation
- Add RefCountedRemovalResult enum and 5 private helpers (removeMCPServerArtifact, removeFileArtifactItem, removeBrewArtifact, removePluginArtifact, removeGitignoreArtifact) - Refactor unconfigurePack, removeNewlyExcludedComponentArtifacts, and reconcileStaleArtifacts to use shared helpers - Centralize ref-counting logic for brew/plugins and do/catch for gitignore entries
- Reword stillNeeded case doc to describe state, not prescribe caller behavior - Replace "Callers handle success/failure logging" with neutral wording - Add inline comment in reconcileStaleArtifacts gitignore else branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts per-artifact-type removal helpers from
Configurator.swiftto reduce duplication acrossunconfigurePack(),removeNewlyExcludedComponentArtifacts(), andreconcileStaleArtifacts(). Pure internal refactor — no behavioral changes.Closes #236
Changes
RefCountedRemovalResultenum (.removed,.stillNeeded,.failed) for 3-way brew/plugin removal semanticsremoveMCPServerArtifact,removeFileArtifactItem,removeBrewArtifact,removePluginArtifact,removeGitignoreArtifactTest plan
swift testpasses locally (4 unrelatedPackFetcherTestsfailures from 1Password SSH agent)swiftformat --lint .andswiftlintpass without violationsmcs sync,mcs doctor)Checklist for engine changes
Only check items that apply to this PR. Delete irrelevant ones.