Conversation
…e entries - Add HookSettingsCheck, SettingsKeysCheck, and PackGitignoreCheck structs - Extract artifactChecks() helper in DoctorRunner for artifact-record-driven checks - Add GitignoreManager.readLines() shared helper, fix GitignoreCheck to use exact line matching
- Replace try? with do/catch in readLines(), SettingsKeysCheck (CLAUDE.md compliance) - Differentiate "not found" vs "unreadable" errors in gitignore checks - Add file-existence check in HookSettingsCheck for clearer error messages - Add test for SettingsKeysCheck with invalid JSON content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Three artifact types tracked by the sync engine in
PackArtifactRecordhad no corresponding doctor verification checks: hook commands in settings, settingsMerge keys, and pack-contributed gitignore entries. If a user manually removed any of these between syncs,mcs doctorwouldn't detect the drift.Changes
HookSettingsCheck— verifies pack hook commands are present in settings fileSettingsKeysCheck— verifies pack settings keys exist (supports dot-notation paths)PackGitignoreCheck— verifies pack gitignore entries are in global gitignoreartifactChecks(for:pack:scope:env:)inDoctorRunnerto group all artifact-record-driven checksGitignoreManager.readLines()shared helper used by bothGitignoreCheckandPackGitignoreCheckGitignoreCheckto use exact line matching (was using substringcontains)Testing
HookSettingsCheckTests,SettingsKeysCheckTests,PackGitignoreCheckTestsswift test)swiftformat+swiftlint)Closes #235