[#101] Add test coverage for LockfileOperations#240
Merged
Conversation
- 16 tests covering writeLockfile, checkoutLockedCommits guard paths, and updatePacks early return - SHA validation regex edge cases: boundary lengths, uppercase rejection, flag injection payloads - Path containment, missing lockfile, missing pack directory, and local pack skip scenarios
bguidolim
force-pushed
the
feature/101-lockfile-operations-tests
branch
from
23d29d0 to
f324df2
Compare
- New Git section enforcing separate commits and regular push only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 16 unit tests for
LockfileOperations.swift, which previously had zero test coverage. Covers security-critical SHA validation, path containment, and the filesystem-basedwriteLockfileflow.Closes #101
Changes
Tests/MCSTests/LockfileOperationsTests.swiftwith 16 tests across three methods:writeLockfile(at:)— 4 tests: basic generation, pack filtering, no-op on empty state, overwrite with driftcheckoutLockedCommits(at:)— 11 tests: missing lockfile, SHA regex boundaries (7-char min, 64-char max, uppercase rejection, 5 flag injection payloads), local pack skipping, path traversal rejection, missing pack directory, mixed pack failureupdatePacks()— 1 test: early return on empty registryTest plan
swift testpasses locallyswiftformat --lint .andswiftlintpass without violations