Skip to content

Added duration field to Activity and create/update endpoints#171

Open
ShalevKk wants to merge 1 commit intomainfrom
feature/shalevkk/46/add-duration-field
Open

Added duration field to Activity and create/update endpoints#171
ShalevKk wants to merge 1 commit intomainfrom
feature/shalevkk/46/add-duration-field

Conversation

@ShalevKk
Copy link
Copy Markdown
Collaborator

@ShalevKk ShalevKk commented Apr 5, 2026

Description

Added new field to Activity entity - duration. Each course needs a duration so that the engine would assign it exactly this number of hours.

Related Issues

Closes bgu-nasa/main#44

Changes Made

  • Added Duration in Activity Domain entity
  • Modified Activity service create and update methods to get also duration param
  • Modified requests/response objects and the activity mapper to contain duration
  • Modified create/update activity endpoints in SubjectController to use the duration field

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing completed
  • All existing tests pass

Checklist

  • My code follows the project's code style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Database Changes

  • No database changes
  • Database migration included
  • Database migration instructions provided below

Configuration Changes

  • No configuration changes required
  • Configuration changes documented below

@ShalevKk ShalevKk self-assigned this Apr 5, 2026
@ShalevKk ShalevKk added enhancement New feature or request feature labels Apr 5, 2026
Copy link
Copy Markdown
Collaborator

@noamarg noamarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants