Skip to content

Feature/shalevkk/44/offboarding hard delete#167

Open
ShalevKk wants to merge 4 commits intomainfrom
feature/shalevkk/44/offboarding-hard-delete
Open

Feature/shalevkk/44/offboarding hard delete#167
ShalevKk wants to merge 4 commits intomainfrom
feature/shalevkk/44/offboarding-hard-delete

Conversation

@ShalevKk
Copy link
Copy Markdown
Collaborator

@ShalevKk ShalevKk commented Apr 4, 2026

Description

Implemented offboarding Remover interface with 2 implementing remover classes - one for Organizations and one for Departments.
The deletion is done with the Data repositories, starting with "leaf" entities that have no reference to other entities, until it reaches to the organization or department.
In each repository a method to delete all entities by the organizationId was implemented, and the same for the relevent repositories with departmentId.
The deletion is an atomic transaction - if it fails before finishing, it will revert the deletion.

Related Issues

Closes bgu-nasa/main#44

Changes Made

  • Created IRemover interface
  • Created OrganizationRemover
  • Created DepartmentRemover
  • Added DeleteAllByOrganizationId in all repositories.
  • Added DeleteAllByDepartmentId in relevant repositories.

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing completed
  • All existing tests pass

Checklist

  • My code follows the project's code style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

@ShalevKk ShalevKk self-assigned this Apr 4, 2026
@ShalevKk ShalevKk added documentation Improvements or additions to documentation enhancement New feature or request feature labels Apr 4, 2026
@ShalevKk ShalevKk requested a review from aaron-iz as a code owner April 4, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant