Crop defaults to true, added behaviour to crop = false#28
Open
jbjanot wants to merge 1 commit intobfintal:masterfrom
jbjanot:master
Open
Crop defaults to true, added behaviour to crop = false#28jbjanot wants to merge 1 commit intobfintal:masterfrom jbjanot:master
jbjanot wants to merge 1 commit intobfintal:masterfrom
jbjanot:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, the crop parameter was unused.
It is now set to true by default.
If you pass crop: false to the parameters, il will resize, but without cropping.
Exemple with a 1200px x 800px source image

This code will result, as expected, in a 100 x 100 pixels image.

Yet, if you use this syntax :
It will result in an image that is 100 x 67 pixels, and not cropped.

Of course, you can still grow images.
And by the way, I used an autoformat tool... Hope you don't mind ;)