Skip to content

Some zTaskBox and xWad5 work#22

Merged
LivewireCB merged 3 commits intobfbbdecomp:mainfrom
bluisblu:main
Jul 19, 2025
Merged

Some zTaskBox and xWad5 work#22
LivewireCB merged 3 commits intobfbbdecomp:mainfrom
bluisblu:main

Conversation

@bluisblu
Copy link
Contributor

No description provided.

@github-actions
Copy link

⚠️ 🔥

+102 bytes
🆗 Bot Rating: A fair and commendable contribution

Regressions: 2

⚠️ main/SB/Core/x/xWad3 - .text -316 bytes -> 35.71%
⚠️ main/SB/Core/x/xWad1 - .text -8 bytes -> 0.00%

Progress: 10

📈 main/SB/Core/x/xWad5 - .text +28 bytes -> 2.94%
📈 main/SB/Game/zTaskBox - .text +76 bytes -> 26.33%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
📈 main/SB/Game/zTaskBox - ztaskbox::set_state(ztaskbox::state_enum) +4 bytes -> 0.70%
📈 main/SB/Game/zTaskBox - ztaskbox::load(const ztaskbox::asset_type&) +3 bytes -> 52.08%
main/SB/Game/zTaskBox - ztaskbox::complete() +28 bytes -> 100.00%
📈 main/SB/Game/zTaskBox - ztaskbox::talk_callback::on_start() +24 bytes -> 77.78%
main/SB/Game/zTaskBox - ztaskbox::talk_callback::on_stop() +7 bytes -> 100.00%
main/SB/Core/x/xWad5 - xCameraFXShakeEnd(cameraFX*, float) +28 bytes -> 100.00%
main/SB/Game/zTaskBox - ztaskbox::talk_callback::reset(ztaskbox&) +8 bytes -> 100.00%

@LivewireCB LivewireCB merged commit 55edc7c into bfbbdecomp:main Jul 19, 2025
4 checks passed
Copy link
Collaborator

@LivewireCB LivewireCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went over the pr in the VC, pointed out that the flag should probably be TRUE instead of 1. Overall great work.

@bluisblu bluisblu changed the title Some xtaskbox and xWad5 work Some zTaskBox and xWad5 work Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants