Skip to content

Fixes Ported Code, and Readds zParticleSystemWaterfall#11

Merged
LivewireCB merged 1 commit intobfbbdecomp:mainfrom
LivewireCB:dev
Apr 28, 2025
Merged

Fixes Ported Code, and Readds zParticleSystemWaterfall#11
LivewireCB merged 1 commit intobfbbdecomp:mainfrom
LivewireCB:dev

Conversation

@LivewireCB
Copy link
Collaborator

Matched functions that were ported. Uncommented all of the zParticleSystemWaterfalls code.

@github-actions
Copy link

⚠️ 🔥

+1165 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

Regressions: 2

⚠️ main/SB/Core/gc/iTRC - .sdata2 -21 bytes -> 0.00%
⚠️ main/SB/Core/gc/iWad - iSGSessionEnd(st_ISGSESSION*) -4 bytes -> 69.44%

Progress: 57

📈 main/SB/Core/gc/iWad - .text +65 bytes -> 39.58%
📈 main/SB/Core/gc/iWad - .text +3 bytes -> 0.12%
📈 main/SB/Game/zParticleSystemWaterfall - .text +732 bytes -> 8.36%
📈 main/SB/Core/gc/iTRC - .text +72 bytes -> 4.66%
📈 main/SB/Core/gc/iWad - .text +15 bytes -> 9.18%
📈 main/SB/Core/gc/iWad - .text +8 bytes -> 1.71%
📈 main/SB/Core/gc/iScrFX - .text +107 bytes -> 2.95%
📈 main/SB/Core/gc/iWad - .text +4 bytes -> 11.83%
📈 main/SB/Core/gc/iWad - .text +23 bytes -> 9.97%
📈 main/SB/Core/gc/iARAMTmp - .text +24 bytes -> 2.34%
📈 main/SB/Core/gc/iWad - .text +604 bytes -> 70.56%
main/SB/Core/gc/iWad - .text +39 bytes -> 100.00%
📈 main/SB/Core/gc/iTRC - .sbss +16 bytes -> 76.19%
📈 main/SB/Game/zParticleSystemWaterfall - .sdata2 +7 bytes -> 9.52%
📈 main/SB/Core/gc/iScrFX - iScrFxCameraEndScene(RwCamera*) +4 bytes -> 0.68%
📈 main/SB/Core/gc/iARAMTmp - iARAMTmpBegin(unsigned int, unsigned int) +4 bytes -> 0.69%
main/SB/Core/gc/iWad - iSG_mcqa_fwrite(st_ISG_MEMCARD_DATA*, char*, int) +8 bytes -> 100.00%
📈 main/SB/Core/gc/iScrFX - iScrFxBegin() +3 bytes -> 1.64%
📈 main/SB/Core/gc/iARAMTmp - iARAMTmpEnd(bool) +4 bytes -> 1.92%
main/SB/Core/gc/iWad - iEnvEndRenderFX(iEnv*) +8 bytes -> 100.00%
📈 main/SB/Core/gc/iARAMTmp - iARAMTmpMalloc(unsigned int) +4 bytes -> 3.70%
main/SB/Core/gc/iWad - iSGSessionBegin(void*, void (*)(void*, en_CHGCODE), int) +17 bytes -> 100.00%
main/SB/Core/gc/iWad - iLightDestroy(iLight*) +44 bytes -> 100.00%
📈 main/SB/Game/zParticleSystemWaterfall - zParticleGeneratorWaterfallSplash::reset() +88 bytes -> 91.67%
📈 main/SB/Game/zParticleSystemWaterfall - zParticleGeneratorWaterfallMist::reset() +88 bytes -> 91.67%
📈 main/SB/Game/zParticleSystemWaterfall - zParticleGeneratorWaterfall::reset() +88 bytes -> 91.67%
main/SB/Core/gc/iWad - iTimeDiffSec(long long, long long) +40 bytes -> 100.00%
📈 main/SB/Core/gc/iWad - malloc +16 bytes -> 75.00%
main/SB/Core/gc/iScrFX - iScrFxCameraDestroyed(RwCamera*) +80 bytes -> 100.00%
📈 main/SB/Core/gc/iARAMTmp - iARAMTmpInARAMTemp(void*) +4 bytes -> 5.00%
main/SB/Core/gc/iWad - iSGShutdown() +44 bytes -> 100.00%
📈 main/SB/Core/gc/iScrFX - iScrFxCameraCreated(RwCamera*) +11 bytes -> 17.65%
main/SB/Game/zParticleSystemWaterfall - zParticleGeneratorWaterfallSplash::activate() +60 bytes -> 100.00%
main/SB/Game/zParticleSystemWaterfall - zParticleGeneratorWaterfallMist::activate() +60 bytes -> 100.00%
main/SB/Game/zParticleSystemWaterfall - zParticleGeneratorWaterfall::activate() +60 bytes -> 100.00%
main/SB/Core/gc/iWad - iCSFileClose(xCutscene*) +4 bytes -> 100.00%
main/SB/Game/zParticleSystemWaterfall - zParticleGeneratorWaterfallSplash::deactivate() +52 bytes -> 100.00%
main/SB/Game/zParticleSystemWaterfall - zParticleGeneratorWaterfallMist::deactivate() +52 bytes -> 100.00%
main/SB/Game/zParticleSystemWaterfall - zParticleGeneratorWaterfall::deactivate() +52 bytes -> 100.00%
📈 main/SB/Core/gc/iARAMTmp - transferDoneCB(unsigned long) +4 bytes -> 8.33%
main/SB/Core/gc/iTRC - iTRCDisk::IsDiskIDed() +40 bytes -> 100.00%
main/SB/Game/zParticleSystemWaterfall - zParticleSystemWaterfallSplash::scene_enter() +36 bytes -> 100.00%
main/SB/Game/zParticleSystemWaterfall - zParticleSystemWaterfallMist::scene_enter() +36 bytes -> 100.00%
main/SB/Game/zParticleSystemWaterfall - zParticleSystemWaterfall::scene_enter() +36 bytes -> 100.00%
📈 main/SB/Core/gc/iWad - iSndExit() +4 bytes -> 12.50%
main/SB/Core/gc/iWad - SetPipelineCB(RpAtomic*, void*) +15 bytes -> 100.00%
main/SB/Core/gc/iWad - iFMVSystemInit() +8 bytes -> 100.00%
main/SB/Core/gc/iTRC - iTRCDisk::SetInFModLockingCode(bool) +8 bytes -> 100.00%
main/SB/Core/gc/iTRC - iTRCDisk::SetMovieResetCallBack(void (*)(void)) +8 bytes -> 100.00%
main/SB/Core/gc/iTRC - iTRCDisk::SetAsyncLoadResumeFunction(void (*)(void)) +8 bytes -> 100.00%
main/SB/Core/gc/iTRC - iTRCDisk::SetAsyncLoadSuspendFunction(void (*)(void)) +8 bytes -> 100.00%
main/SB/Game/zParticleSystemWaterfall - zParticleSystemWaterfallSplash::get_asset_size() const +8 bytes -> 100.00%
main/SB/Game/zParticleSystemWaterfall - zParticleSystemWaterfallMist::get_asset_size() const +8 bytes -> 100.00%
main/SB/Game/zParticleSystemWaterfall - zParticleSystemWaterfall::get_asset_size() const +8 bytes -> 100.00%
main/SB/Core/gc/iScrFX - iScrFxLensFlare_Reset() +4 bytes -> 100.00%
main/SB/Core/gc/iScrFX - iScrFxInit() +4 bytes -> 100.00%
main/SB/Core/gc/iARAMTmp - iARAMTmpFree(void*) +4 bytes -> 100.00%

@LivewireCB LivewireCB merged commit ec7d4c9 into bfbbdecomp:main Apr 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant