Completed and Linked xUpdateCull, and xPtankPool#677
Merged
JoshSanch merged 3 commits intobfbbdecomp:mainfrom Nov 29, 2025
Merged
Completed and Linked xUpdateCull, and xPtankPool#677JoshSanch merged 3 commits intobfbbdecomp:mainfrom
JoshSanch merged 3 commits intobfbbdecomp:mainfrom
Conversation
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ️ |
.data |
100.00% | 0.00% | --208 |
| ️ |
.rodata |
100.00% | 0.00% | --992 |
| ️ |
.sbss |
100.00% | 85.71% | --3 |
| ️ |
.sdata2 |
85.71% | 0.00% | --27 |
| ️ |
.text |
78.48% | 16.80% | --885 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ️ |
render_message(const char*) |
88.21% | 0.00% | --335 |
| ❔ | xTRCReset() |
77.78% | 77.50% | +/-0 |
| ️ |
render_mem_card_no_space(int, int, int, bool) |
94.74% | 0.00% | --147 |
| ️ |
RenderText(const char*, bool) |
93.18% | 0.00% | --402 |
main/SB/Core/x/xUpdateCull
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .text |
23.65% | 100.00% | +1872 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | xUpdateCull_DistanceSquaredCB(void*, void*) |
0.00% | 100.00% | +120 |
| ✅ | xUpdateCull_Init(void**, unsigned int, xGroup**, unsigned int) |
0.00% | 100.00% | +1260 |
| ✅ | xUpdateCull_Update(xUpdateCullMgr*, unsigned int) |
0.00% | 100.00% | +492 |
main/SB/Core/x/xPtankPool
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .text |
98.79% | 100.00% | +31 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | @unnamed@xPtankPool_cpp@::create_ptank(unsigned int) |
84.62% | 100.00% | +31 |
main/SB/Game/zNPCHazard
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ️ |
.data |
4.55% | 2.80% | --20 |
| ️ |
.rodata |
29.82% | 17.44% | --205 |
| ️ |
.sbss |
90.48% | 64.71% | --24 |
| ️ |
.sdata2 |
38.82% | 33.48% | --18 |
| ️ |
.text |
50.63% | 34.43% | --5622 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ️ |
NPCHazard::Upd_PuppyNuke(float) |
100.00% | 0.00% | --240 |
| ️ |
NPCHazard::Upd_FodBomb(float) |
100.00% | 0.00% | --252 |
| ️ |
NPCHazard::FodBombBubbles(float) |
99.85% | 0.00% | --247 |
| ️ |
NPCHazard::Upd_CattleProd(float) |
98.43% | 0.00% | --803 |
| ️ |
NPCHazard::Upd_TubeletBlast(float) |
94.50% | 0.00% | --461 |
| ️ |
NPCHazard::Upd_DuploBoom(float) |
100.00% | 0.00% | --208 |
| ️ |
NPCHazard::Upd_TikiThunder(float) |
100.00% | 0.00% | --204 |
| ️ |
NPCHazard::Upd_Mushroom(float) |
100.00% | 0.00% | --272 |
| ️ |
NPCHazard::Upd_TTFlight(float) |
98.34% | 0.00% | --959 |
| ️ |
NPCHazard::ReconTarTar() |
94.76% | 0.00% | --159 |
| ️ |
NPCHazard::Upd_TTSpill(float) |
100.00% | 0.00% | --228 |
| ️ |
NPCHazard::Upd_TTStink(float) |
100.00% | 0.00% | --184 |
| ️ |
NPCHazard::Upd_FunFrag(float) |
100.00% | 0.00% | --328 |
| ️ |
NPCHazard::StreakUpdate(unsigned int, float) |
100.00% | 0.00% | --256 |
| ️ |
NPCHazard::Upd_RoboBits(float) |
100.00% | 0.00% | --360 |
| ️ |
NPCHazard::Upd_VisSplash(float) |
100.00% | 0.00% | --136 |
| ️ |
NPCHazard::VisSplashSparklies() |
100.00% | 0.00% | --324 |
main/bink/shared/time/radcb
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .text |
23.80% | 63.04% | +692 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | RADCB_register_callback |
0.00% | 3.70% | +4 |
| 📈 | RADCB_unregister_callback |
0.00% | 79.05% | +135 |
| ✅ | RADCB_unregister_2_callbacks |
4.76% | 100.00% | +80 |
| ✅ | RADCB_try_to_suspend_handler |
3.57% | 100.00% | +108 |
| ✅ | RADCB_resume_handler |
99.86% | 100.00% | +/-0 |
| ✅ | RADCB_try_to_suspend_callback |
2.70% | 100.00% | +144 |
| ✅ | RADCB_suspend_callback |
3.70% | 100.00% | +103 |
| ✅ | RADCB_resume_callback |
3.33% | 100.00% | +116 |
JoshSanch
reviewed
Nov 29, 2025
| u32 FrameRateDiv; // frame rate divisor | ||
| u32 Frames; // frames in this sample period | ||
| u32 FramesTime; // time is ms for these frames | ||
| volatile u32 FramesTime; // time is ms for these frames |
Collaborator
There was a problem hiding this comment.
Would be good if you could document here or elsewhere why you decided these needed to be marked volatile.
Contributor
Author
There was a problem hiding this comment.
Marked with TODO: in bother bink.h and radcb.c
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .text |
23.65% | 100.00% | +1872 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | xUpdateCull_DistanceSquaredCB(void*, void*) |
0.00% | 100.00% | +120 |
| ✅ | xUpdateCull_Init(void**, unsigned int, xGroup**, unsigned int) |
0.00% | 100.00% | +1260 |
| ✅ | xUpdateCull_Update(xUpdateCullMgr*, unsigned int) |
0.00% | 100.00% | +492 |
main/SB/Core/x/xPtankPool
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .text |
98.79% | 100.00% | +31 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | @unnamed@xPtankPool_cpp@::create_ptank(unsigned int) |
84.62% | 100.00% | +31 |
main/bink/shared/time/radcb
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .text |
23.80% | 63.04% | +692 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | RADCB_register_callback |
0.00% | 3.70% | +4 |
| 📈 | RADCB_unregister_callback |
0.00% | 79.05% | +135 |
| ✅ | RADCB_unregister_2_callbacks |
4.76% | 100.00% | +80 |
| ✅ | RADCB_try_to_suspend_handler |
3.57% | 100.00% | +108 |
| ✅ | RADCB_resume_handler |
99.86% | 100.00% | +/-0 |
| ✅ | RADCB_try_to_suspend_callback |
2.70% | 100.00% | +144 |
| ✅ | RADCB_suspend_callback |
3.70% | 100.00% | +103 |
| ✅ | RADCB_resume_callback |
3.33% | 100.00% | +116 |
JoshSanch
reviewed
Nov 29, 2025
src/SB/Core/x/xPtankPool.cpp
Outdated
| group_data* end = groups + MAX_PGT; | ||
| while (it != end) | ||
| { | ||
| double f = it->max_size - 0.f; |
Collaborator
There was a problem hiding this comment.
Do these need to be Heavy Iron-typed? We have F64 for doubles and u32 for unsigned long.
Contributor
Author
There was a problem hiding this comment.
I honestly don't know as I didn't actually do the function, just fixed it. Will update that now.
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .text |
23.65% | 100.00% | +1872 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | xUpdateCull_DistanceSquaredCB(void*, void*) |
0.00% | 100.00% | +120 |
| ✅ | xUpdateCull_Init(void**, unsigned int, xGroup**, unsigned int) |
0.00% | 100.00% | +1260 |
| ✅ | xUpdateCull_Update(xUpdateCullMgr*, unsigned int) |
0.00% | 100.00% | +492 |
main/SB/Core/x/xPtankPool
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .text |
98.79% | 100.00% | +31 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | @unnamed@xPtankPool_cpp@::create_ptank(unsigned int) |
84.62% | 100.00% | +31 |
main/bink/shared/time/radcb
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .text |
23.80% | 63.04% | +692 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | RADCB_register_callback |
0.00% | 3.70% | +4 |
| 📈 | RADCB_unregister_callback |
0.00% | 79.05% | +135 |
| ✅ | RADCB_unregister_2_callbacks |
4.76% | 100.00% | +80 |
| ✅ | RADCB_try_to_suspend_handler |
3.57% | 100.00% | +108 |
| ✅ | RADCB_resume_handler |
99.86% | 100.00% | +/-0 |
| ✅ | RADCB_try_to_suspend_callback |
2.70% | 100.00% | +144 |
| ✅ | RADCB_suspend_callback |
3.70% | 100.00% | +103 |
| ✅ | RADCB_resume_callback |
3.33% | 100.00% | +116 |
JoshSanch
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.