Merged
Conversation
…method commented to be a stub.
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .data |
0.00% | 68.38% | +38 |
| 📈 | .rodata |
0.00% | 46.88% | +26 |
| ✅ | .sbss |
0.00% | 100.00% | +8 |
| 📈 | .sdata2 |
0.00% | 68.75% | +16 |
| 📈 | .text |
0.00% | 40.98% | +572 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | xhud::font_meter_widget::load(xBase&, xDynAsset&, unsigned long) |
0.00% | 4.55% | +4 |
| ✅ | xhud::font_meter_widget::destruct() |
0.00% | 100.00% | +32 |
| ✅ | xhud::font_meter_widget::destroy() |
0.00% | 100.00% | +32 |
| 📈 | xhud::font_meter_widget::update(float) |
0.00% | 60.99% | +300 |
| ✅ | xhud::font_meter_widget::render() |
0.00% | 100.00% | +192 |
| ✅ | xhud::font_meter_asset::type_name() |
0.00% | 100.00% | +12 |
SquareMan
requested changes
Nov 18, 2025
src/SB/Core/x/xHudFontMeter.cpp
Outdated
|
|
||
| void xhud::font_meter_widget::destruct() | ||
| { | ||
| ((xhud::meter_widget*)this)->destruct(); |
Member
There was a problem hiding this comment.
Prefer xhud::meter_widget::destruct() to call a base class virtual function over manually casting the this pointer.
src/SB/Core/x/xHudFontMeter.cpp
Outdated
Comment on lines
+88
to
+96
| (*this).updater(dt); | ||
| this->xf.id = (this->font).id; | ||
| this->xf.space = (this->font).space; | ||
| a = (*this).rc.size.x; | ||
| this->font.w = a; | ||
| this->xf.width = a; | ||
| a = (*this).rc.size.y; | ||
| this->font.h = a; | ||
| this->xf.height = a; |
Member
There was a problem hiding this comment.
(*this). is the same as this->, you should use the arrow operator here for consistency and readability. Additionally the redundant parentheses should be cleaned up (i.e this->font.id instead of (this->font).id. Same goes for the rest of the additions in this file.
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | .data |
0.00% | 68.38% | +38 |
| 📈 | .rodata |
0.00% | 46.88% | +26 |
| ✅ | .sbss |
0.00% | 100.00% | +8 |
| 📈 | .sdata2 |
0.00% | 68.75% | +16 |
| 📈 | .text |
0.00% | 40.98% | +572 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| 📈 | xhud::font_meter_widget::load(xBase&, xDynAsset&, unsigned long) |
0.00% | 4.55% | +4 |
| ✅ | xhud::font_meter_widget::destruct() |
0.00% | 100.00% | +32 |
| ✅ | xhud::font_meter_widget::destroy() |
0.00% | 100.00% | +32 |
| 📈 | xhud::font_meter_widget::update(float) |
0.00% | 60.99% | +300 |
| ✅ | xhud::font_meter_widget::render() |
0.00% | 100.00% | +192 |
| ✅ | xhud::font_meter_asset::type_name() |
0.00% | 100.00% | +12 |
escape209
pushed a commit
to escape209/bfbbdecomp
that referenced
this pull request
Nov 19, 2025
* xHudFontMeter overhead * Method for converting color32u to iColor_tag * Generally okay matches for xHudFontMeter * Seeing if it builds with new commented out * Other build fix (thanks Sway) * Revert, this was fine * My redefinition of the load method was breaking things. Reverted and method commented to be a stub. * Square tweaks Work DO NOT PR xEntBoulder progress xEntBoulder progress Mostly match xEntBoulder_Update Match more stuff
escape209
pushed a commit
to escape209/bfbbdecomp
that referenced
this pull request
Nov 19, 2025
* xHudFontMeter overhead * Method for converting color32u to iColor_tag * Generally okay matches for xHudFontMeter * Seeing if it builds with new commented out * Other build fix (thanks Sway) * Revert, this was fine * My redefinition of the load method was breaking things. Reverted and method commented to be a stub. * Square tweaks Work DO NOT PR xEntBoulder progress xEntBoulder progress Mostly match xEntBoulder_Update Match more stuff
escape209
pushed a commit
to escape209/bfbbdecomp
that referenced
this pull request
Nov 19, 2025
* xHudFontMeter overhead * Method for converting color32u to iColor_tag * Generally okay matches for xHudFontMeter * Seeing if it builds with new commented out * Other build fix (thanks Sway) * Revert, this was fine * My redefinition of the load method was breaking things. Reverted and method commented to be a stub. * Square tweaks
escape209
pushed a commit
to escape209/bfbbdecomp
that referenced
this pull request
Nov 19, 2025
* xHudFontMeter overhead * Method for converting color32u to iColor_tag * Generally okay matches for xHudFontMeter * Seeing if it builds with new commented out * Other build fix (thanks Sway) * Revert, this was fine * My redefinition of the load method was breaking things. Reverted and method commented to be a stub. * Square tweaks Work DO NOT PR xEntBoulder progress xEntBoulder progress Mostly match xEntBoulder_Update Match more stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful groundwork for xHudFontMeter, all methods for this file.