Misc work by escape209 · Pull Request #610 · bfbbdecomp/bfbb

escape209 · 2025-10-12T14:23:07Z

No description provided.

github-actions · 2025-10-12T14:24:39Z

⚠️ 🔥

+833 bytes
🆗 Bot Rating: Ay, díos mio, gracias por la contribución!

Regressions: 48

⚠️ main/SB/Core/gc/iCollide - .bss -64 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - .sbss -40 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - .sdata2 -29 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - .text -5452 bytes -> 0.05%
⚠️ main/SB/Core/gc/iCollide - .text -100 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - .bss -728 bytes -> 8.08%
⚠️ main/SB/Game/zNPCTypeTiki - .data -196 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - .sbss -5 bytes -> 66.67%
⚠️ main/SB/Game/zNPCTypeTiki - .sdata -40 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - .sdata2 -18 bytes -> 57.75%
⚠️ main/SB/Game/zNPCTypeTiki - .text -3464 bytes -> 18.18%
⚠️ main/SB/Core/x/xShadowSimple - .sdata2 -11 bytes -> 13.33%
⚠️ main/SB/Core/x/xShadowSimple - .text -80 bytes -> 7.19%
⚠️ main/SB/Core/gc/iCollide - PointWithinTriangle(xVec3*, xVec3**, xVec3*) -648 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - FindNearestPointOnLine(xVec3*, xVec3*, xVec3*, xVec3*) -124 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - properSphereIsectTri(const xVec3*, float, xVec3*, float*, RpCollisionTriangle*) -372 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - sphereHitsEnvCB(RpIntersection*, RpWorldSector*, RpCollisionTriangle*, float, void*) -368 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - sphereHitsEnv3CB(RpIntersection*, RpWorldSector*, RpCollisionTriangle*, float, void*) -948 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - sphereHitsEnv4CB(RpIntersection*, RpWorldSector*, RpCollisionTriangle*, float, void*) -452 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - sphereHitsModel3CB(RpIntersection*, RpCollisionTriangle*, float, void*) -56 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - rayHitsEnvCB(RpIntersection*, RpWorldSector*, RpCollisionTriangle*, float, void*) -244 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - rayHitsEnvBackwardCB(RpIntersection*, RpWorldSector*, RpCollisionTriangle*, float, void*) -148 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - rayHitsModelCB(RpIntersection*, RpCollisionTriangle*, float, void*) -44 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - rayHitsModelBackwardCB(RpIntersection*, RpCollisionTriangle*, float, void*) -44 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - iSphereHitsEnv(const xSphere*, const xEnv*, xCollis*) -228 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - iSphereHitsEnv3(const xSphere*, const xEnv*, xCollis*, unsigned char, float) -528 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - iSphereHitsEnv4(const xSphere*, const xEnv*, const xMat3x3*, xCollis*) -604 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - iSphereHitsModel3(const xSphere*, const xModelInstance*, xCollis*, unsigned char, float) -644 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - xMat3x3RMulVec(xVec3*, const xMat3x3*, const xVec3*) -100 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_InitStacking(zScene*) -4 bytes -> 98.44%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_InitFX(zScene*) -469 bytes -> 30.52%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_PickTikisToAnimate() -4 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_Timestep(xScene*, float) -48 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_ReparentOrphans() -196 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::Reset() -32 bytes -> 92.45%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::Init(xEntAsset*) -336 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::SetCarryState(en_NPC_CARRY_STATE) -414 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::SelfSetup() -367 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::Process(xScene*, float) -140 bytes -> 24.03%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::SysEvent(xBase*, xBase*, unsigned int, const float*, xBase*, int*) -292 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::AddChild(zNPCTiki*) -64 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::RemoveChild(zNPCTiki*) -104 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::RemoveParent(zNPCTiki*) -144 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::ParentUpdated(zNPCTiki*) -68 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::RemoveFromFamily() -204 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - loveyFloat(zNPCTiki*, float) -176 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - loveyTikiRender(xEnt*) -400 bytes -> 0.00%
⚠️ main/SB/Core/x/xShadowSimple - xShadowSimple_CacheInit(xShadowSimpleCache*, xEnt*, unsigned char) -80 bytes -> 0.00%

Progress: 18

📈 main/SB/Core/x/xFont - .text +244 bytes -> 80.43%
📈 main/SB/Core/x/xMath3 - .text +320 bytes -> 60.40%
📈 main/SB/Core/x/xMath - .text +128 bytes -> 82.16%
📈 main/SB/Core/x/xBound - .text +56 bytes -> 89.15%
✅ main/SB/Core/x/xCamera - .text +16 bytes -> 100.00%
✅ main/SB/Core/x/xBound - .text +35 bytes -> 100.00%
✅ main/SB/Core/x/xCamera - .text +35 bytes -> 100.00%
📈 main/SB/Core/x/xBound - xBoundOBBIsectRay(const xBox*, const xMat4x3*, const xRay3*, xIsect*) +4 bytes -> 80.69%
📈 main/SB/Core/x/xMath - xAccelMove(float&, float&, float, float, float, float) +91 bytes -> 99.45%
✅ main/SB/Core/x/xMath3 - xMat3x3Tolocal(xVec3*, const xMat3x3*, const xVec3*) +224 bytes -> 100.00%
✅ main/SB/Core/x/xFont - xtextbox::operator=(const xtextbox&) +212 bytes -> 100.00%
✅ main/SB/Core/x/xMath3 - xMat3x3LMulVec(xVec3*, const xMat3x3*, const xVec3*) +96 bytes -> 100.00%
✅ main/SB/Core/x/xMath - xFuncPiece_EndPoints(xFuncPiece*, float, float, float, float) +35 bytes -> 100.00%
✅ main/SB/Core/x/xFont - rwGameCube2DVertex::operator=(const rwGameCube2DVertex&) +32 bytes -> 100.00%
✅ main/SB/Core/x/xBound - xBox::operator=(const xBox&) +52 bytes -> 100.00%
✅ main/SB/Core/x/xCamera - xVec3::operator/=(float) +15 bytes -> 100.00%
✅ main/SB/Core/x/xBound - xSphere::operator=(const xSphere&) +36 bytes -> 100.00%
✅ main/SB/Core/x/xCamera - xQuat::operator=(const xQuat&) +36 bytes -> 100.00%

github-actions · 2025-10-12T22:47:08Z

⚠️ 🔥

+888 bytes
🆗 Bot Rating: Ay, díos mio, gracias por la contribución!

Regressions: 46

⚠️ main/SB/Core/gc/iCollide - .bss -64 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - .sbss -40 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - .sdata2 -29 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - .text -5452 bytes -> 0.05%
⚠️ main/SB/Core/gc/iCollide - .text -100 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - .bss -728 bytes -> 8.08%
⚠️ main/SB/Game/zNPCTypeTiki - .data -196 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - .sbss -5 bytes -> 66.67%
⚠️ main/SB/Game/zNPCTypeTiki - .sdata -40 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - .sdata2 -18 bytes -> 57.75%
⚠️ main/SB/Game/zNPCTypeTiki - .text -3372 bytes -> 18.82%
⚠️ main/SB/Core/x/xShadowSimple - .sdata2 -11 bytes -> 13.33%
⚠️ main/SB/Core/x/xShadowSimple - .text -80 bytes -> 7.19%
⚠️ main/SB/Core/gc/iCollide - PointWithinTriangle(xVec3*, xVec3**, xVec3*) -648 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - FindNearestPointOnLine(xVec3*, xVec3*, xVec3*, xVec3*) -124 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - properSphereIsectTri(const xVec3*, float, xVec3*, float*, RpCollisionTriangle*) -372 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - sphereHitsEnvCB(RpIntersection*, RpWorldSector*, RpCollisionTriangle*, float, void*) -368 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - sphereHitsEnv3CB(RpIntersection*, RpWorldSector*, RpCollisionTriangle*, float, void*) -948 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - sphereHitsEnv4CB(RpIntersection*, RpWorldSector*, RpCollisionTriangle*, float, void*) -452 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - sphereHitsModel3CB(RpIntersection*, RpCollisionTriangle*, float, void*) -56 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - rayHitsEnvCB(RpIntersection*, RpWorldSector*, RpCollisionTriangle*, float, void*) -244 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - rayHitsEnvBackwardCB(RpIntersection*, RpWorldSector*, RpCollisionTriangle*, float, void*) -148 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - rayHitsModelCB(RpIntersection*, RpCollisionTriangle*, float, void*) -44 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - rayHitsModelBackwardCB(RpIntersection*, RpCollisionTriangle*, float, void*) -44 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - iSphereHitsEnv(const xSphere*, const xEnv*, xCollis*) -228 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - iSphereHitsEnv3(const xSphere*, const xEnv*, xCollis*, unsigned char, float) -528 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - iSphereHitsEnv4(const xSphere*, const xEnv*, const xMat3x3*, xCollis*) -604 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - iSphereHitsModel3(const xSphere*, const xModelInstance*, xCollis*, unsigned char, float) -644 bytes -> 0.00%
⚠️ main/SB/Core/gc/iCollide - xMat3x3RMulVec(xVec3*, const xMat3x3*, const xVec3*) -100 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_InitFX(zScene*) -469 bytes -> 30.52%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_PickTikisToAnimate() -4 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_Timestep(xScene*, float) -48 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_ReparentOrphans() -196 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::Init(xEntAsset*) -336 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::SetCarryState(en_NPC_CARRY_STATE) -414 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::SelfSetup() -367 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::Process(xScene*, float) -140 bytes -> 24.03%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::SysEvent(xBase*, xBase*, unsigned int, const float*, xBase*, int*) -292 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::AddChild(zNPCTiki*) -64 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::RemoveChild(zNPCTiki*) -104 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::RemoveParent(zNPCTiki*) -144 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::ParentUpdated(zNPCTiki*) -68 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::RemoveFromFamily() -204 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - loveyFloat(zNPCTiki*, float) -176 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - loveyTikiRender(xEnt*) -400 bytes -> 0.00%
⚠️ main/SB/Core/x/xShadowSimple - xShadowSimple_CacheInit(xShadowSimpleCache*, xEnt*, unsigned char) -80 bytes -> 0.00%

Progress: 19

📈 main/SB/Core/x/xFont - .text +244 bytes -> 80.43%
📈 main/SB/Core/x/xMath3 - .text +320 bytes -> 60.40%
📈 main/SB/Core/x/xMath - .text +128 bytes -> 82.16%
📈 main/SB/Core/x/xBound - .text +56 bytes -> 89.15%
✅ main/SB/Core/x/xCamera - .text +16 bytes -> 100.00%
✅ main/SB/Core/x/xBound - .text +35 bytes -> 100.00%
✅ main/SB/Core/x/xCamera - .text +35 bytes -> 100.00%
📈 main/SB/Core/x/xBound - xBoundOBBIsectRay(const xBox*, const xMat4x3*, const xRay3*, xIsect*) +4 bytes -> 80.69%
📈 main/SB/Core/x/xMath - xAccelMove(float&, float&, float, float, float, float) +91 bytes -> 99.45%
✅ main/SB/Game/zNPCTypeTiki - genericTikiRender(xEnt*) +55 bytes -> 100.00%
✅ main/SB/Core/x/xMath3 - xMat3x3Tolocal(xVec3*, const xMat3x3*, const xVec3*) +224 bytes -> 100.00%
✅ main/SB/Core/x/xFont - xtextbox::operator=(const xtextbox&) +212 bytes -> 100.00%
✅ main/SB/Core/x/xMath3 - xMat3x3LMulVec(xVec3*, const xMat3x3*, const xVec3*) +96 bytes -> 100.00%
✅ main/SB/Core/x/xMath - xFuncPiece_EndPoints(xFuncPiece*, float, float, float, float) +35 bytes -> 100.00%
✅ main/SB/Core/x/xFont - rwGameCube2DVertex::operator=(const rwGameCube2DVertex&) +32 bytes -> 100.00%
✅ main/SB/Core/x/xBound - xBox::operator=(const xBox&) +52 bytes -> 100.00%
✅ main/SB/Core/x/xCamera - xVec3::operator/=(float) +15 bytes -> 100.00%
✅ main/SB/Core/x/xBound - xSphere::operator=(const xSphere&) +36 bytes -> 100.00%
✅ main/SB/Core/x/xCamera - xQuat::operator=(const xQuat&) +36 bytes -> 100.00%

JoshSanch

LGTM!

JoshSanch

Please fix the merge conflicts - looks good otherwise.

github-actions · 2025-10-13T09:17:52Z

🆗 ✅

+888 bytes
🆗 Bot Rating: Ay, díos mio, gracias por la contribución!

No Regressions 🎉

Progress: 20

📈 main/SB/Core/x/xFont - .text +244 bytes -> 80.43%
📈 main/SB/Game/zNPCTypeTiki - .text +55 bytes -> 42.83%
📈 main/SB/Core/x/xMath3 - .text +320 bytes -> 60.40%
📈 main/SB/Core/x/xMath - .text +128 bytes -> 82.16%
📈 main/SB/Core/x/xBound - .text +56 bytes -> 89.15%
✅ main/SB/Core/x/xCamera - .text +16 bytes -> 100.00%
✅ main/SB/Core/x/xBound - .text +35 bytes -> 100.00%
✅ main/SB/Core/x/xCamera - .text +35 bytes -> 100.00%
📈 main/SB/Core/x/xBound - xBoundOBBIsectRay(const xBox*, const xMat4x3*, const xRay3*, xIsect*) +4 bytes -> 80.69%
📈 main/SB/Core/x/xMath - xAccelMove(float&, float&, float, float, float, float) +91 bytes -> 99.45%
✅ main/SB/Game/zNPCTypeTiki - genericTikiRender(xEnt*) +55 bytes -> 100.00%
✅ main/SB/Core/x/xMath3 - xMat3x3Tolocal(xVec3*, const xMat3x3*, const xVec3*) +224 bytes -> 100.00%
✅ main/SB/Core/x/xFont - xtextbox::operator=(const xtextbox&) +212 bytes -> 100.00%
✅ main/SB/Core/x/xMath3 - xMat3x3LMulVec(xVec3*, const xMat3x3*, const xVec3*) +96 bytes -> 100.00%
✅ main/SB/Core/x/xMath - xFuncPiece_EndPoints(xFuncPiece*, float, float, float, float) +35 bytes -> 100.00%
✅ main/SB/Core/x/xFont - rwGameCube2DVertex::operator=(const rwGameCube2DVertex&) +32 bytes -> 100.00%
✅ main/SB/Core/x/xBound - xBox::operator=(const xBox&) +52 bytes -> 100.00%
✅ main/SB/Core/x/xCamera - xVec3::operator/=(float) +15 bytes -> 100.00%
✅ main/SB/Core/x/xBound - xSphere::operator=(const xSphere&) +36 bytes -> 100.00%
✅ main/SB/Core/x/xCamera - xQuat::operator=(const xQuat&) +36 bytes -> 100.00%

Misc work

da33328

Match genericTikiRender, couple fixes

c1628e3

JoshSanch approved these changes Oct 13, 2025

View reviewed changes

JoshSanch self-requested a review October 13, 2025 04:46

JoshSanch requested changes Oct 13, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into work

bb38aad

JoshSanch merged commit 9270175 into bfbbdecomp:main Oct 14, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Misc work#610

Misc work#610
JoshSanch merged 3 commits intobfbbdecomp:mainfrom
escape209:work

escape209 commented Oct 12, 2025

Uh oh!

github-actions bot commented Oct 12, 2025

Uh oh!

github-actions bot commented Oct 12, 2025

Uh oh!

JoshSanch left a comment

Uh oh!

JoshSanch left a comment

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

escape209 commented Oct 12, 2025

Uh oh!

github-actions bot commented Oct 12, 2025

⚠️ 🔥

Regressions: 48

Progress: 18

Uh oh!

github-actions bot commented Oct 12, 2025

⚠️ 🔥

Regressions: 46

Progress: 19

Uh oh!

JoshSanch left a comment

Choose a reason for hiding this comment

Uh oh!

JoshSanch left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 13, 2025

🆗 ✅

No Regressions 🎉

Progress: 20

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants