zNPCTypeBossSB2 by LSLees · Pull Request #604 · bfbbdecomp/bfbb

LSLees · 2025-10-07T13:33:43Z

Constructors for most structs, and their equivalent 'create' functions. And few other small functions.

github-actions · 2025-10-07T13:35:19Z

🆗 ✅

+2431 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 30

📈 main/SB/Game/zNPCTypeBossSB2 - .text +1564 bytes -> 34.65%
📈 main/SB/Game/zNPCTypeBossSB2 - .text +815 bytes -> 65.47%
📈 main/SB/Game/zNPCTypeBossSB2 - .data +51 bytes -> 80.27%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Chop::Enter(float, void*) +212 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Swipe::Enter(float, void*) +200 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Karate::Enter(float, void*) +32 bytes -> 21.62%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Intro::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Idle::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Taunt::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Dizzy::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Hit::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Hunt::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Swipe::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Chop::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Karate::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Death::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Intro::zNPCGoalBossSB2Intro(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Idle::zNPCGoalBossSB2Idle(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Taunt::zNPCGoalBossSB2Taunt(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Dizzy::zNPCGoalBossSB2Dizzy(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Hit::zNPCGoalBossSB2Hit(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Hunt::zNPCGoalBossSB2Hunt(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Swipe::zNPCGoalBossSB2Swipe(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Chop::zNPCGoalBossSB2Chop(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Karate::zNPCGoalBossSB2Karate(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Death::zNPCGoalBossSB2Death(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::location() const +16 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::facing() const +16 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::get_home() const +12 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::start_location() const +12 bytes -> 100.00%

JoshSanch

Great work! Just a couple of change requests from me.

src/SB/Game/zNPCTypeBossSB2.cpp

github-actions · 2025-10-07T21:59:56Z

🆗 ✅

+2431 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 30

📈 main/SB/Game/zNPCTypeBossSB2 - .text +1564 bytes -> 34.65%
📈 main/SB/Game/zNPCTypeBossSB2 - .text +815 bytes -> 65.47%
📈 main/SB/Game/zNPCTypeBossSB2 - .data +51 bytes -> 80.27%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Chop::Enter(float, void*) +212 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Swipe::Enter(float, void*) +200 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Karate::Enter(float, void*) +32 bytes -> 21.62%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Intro::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Idle::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Taunt::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Dizzy::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Hit::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Hunt::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Swipe::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Chop::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Karate::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Death::create(int, RyzMemGrow*, void*) +112 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Intro::zNPCGoalBossSB2Intro(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Idle::zNPCGoalBossSB2Idle(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Taunt::zNPCGoalBossSB2Taunt(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Dizzy::zNPCGoalBossSB2Dizzy(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Hit::zNPCGoalBossSB2Hit(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Hunt::zNPCGoalBossSB2Hunt(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Swipe::zNPCGoalBossSB2Swipe(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Chop::zNPCGoalBossSB2Chop(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Karate::zNPCGoalBossSB2Karate(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Death::zNPCGoalBossSB2Death(int, zNPCB_SB2&) +76 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::location() const +16 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::facing() const +16 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::get_home() const +12 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::start_location() const +12 bytes -> 100.00%

JoshSanch

LGTM, thanks!

LSLees and others added 6 commits October 3, 2025 20:07

SB2Chop::Enter

2dd0644

Merge branch 'bfbbdecomp:main' into zNPC_TB_SB2

ad47e3b

Replaced float with F32

f59cdd0

Swipe::Enter

215a1c7

Merge branch 'bfbbdecomp:main' into zNPC_TB_SB2

8c7ee5d

Copy and paste :)

c1898a0

JoshSanch requested changes Oct 7, 2025

View reviewed changes

src/SB/Game/zNPCTypeBossSB2.cpp Outdated Show resolved Hide resolved

src/SB/Game/zNPCTypeBossSB2.cpp Outdated Show resolved Hide resolved

Proper naming conventions

89f0d97

JoshSanch approved these changes Oct 7, 2025

View reviewed changes

JoshSanch merged commit 0928892 into bfbbdecomp:main Oct 7, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zNPCTypeBossSB2#604

zNPCTypeBossSB2#604
JoshSanch merged 7 commits intobfbbdecomp:mainfrom
LSLees:zNPC_TB_SB2

LSLees commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

JoshSanch left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

JoshSanch left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LSLees commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

🆗 ✅

No Regressions 🎉

Progress: 30

Uh oh!

JoshSanch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025

🆗 ✅

No Regressions 🎉

Progress: 30

Uh oh!

JoshSanch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants