Skip to content

Start on xShadowSimple, partial match of xShadowSimple_CacheInit#603

Merged
JoshSanch merged 2 commits intobfbbdecomp:mainfrom
daft7:DaftShadow
Oct 10, 2025
Merged

Start on xShadowSimple, partial match of xShadowSimple_CacheInit#603
JoshSanch merged 2 commits intobfbbdecomp:mainfrom
daft7:DaftShadow

Conversation

@daft7
Copy link
Contributor

@daft7 daft7 commented Oct 7, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

🆗 ✅

+91 bytes
🆗 Bot Rating: A small contribution, every little bit helps!

No Regressions 🎉

Progress: 3

📈 main/SB/Core/x/xShadowSimple - .text +80 bytes -> 8.82%
📈 main/SB/Core/x/xShadowSimple - .sdata2 +11 bytes -> 36.84%
📈 main/SB/Core/x/xShadowSimple - xShadowSimple_CacheInit(xShadowSimpleCache*, xEnt*, unsigned char) +80 bytes -> 22.73%

@JoshSanch
Copy link
Collaborator

Hey Daft, this is a great start to this - if you've got time, I'd love to see you work with the Discord to progress this one further before I merge it. If you're short on time though, we're good to accept this as is.

@github-actions
Copy link

⚠️ 🔥

+203 bytes
🆗 Bot Rating: A fair and commendable contribution

Regressions: 79

⚠️ main/SB/Game/zMain - .sbss2 -12 bytes -> 0.00%
⚠️ main/SB/Game/zMain - .sdata2 -43 bytes -> 61.90%
⚠️ main/SB/Game/zMain - .text -203 bytes -> 61.70%
⚠️ main/SB/Game/zNPCTypeTiki - .bss -728 bytes -> 8.08%
⚠️ main/SB/Game/zNPCTypeTiki - .data -196 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - .sbss -5 bytes -> 66.67%
⚠️ main/SB/Game/zNPCTypeTiki - .sdata -40 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - .sdata2 -18 bytes -> 57.75%
⚠️ main/SB/Game/zNPCTypeTiki - .text -3464 bytes -> 18.18%
⚠️ main/SB/Game/zNPCTypeBossSB2 - .data -51 bytes -> 74.31%
⚠️ main/SB/Game/zNPCTypeBossSB2 - .text -1564 bytes -> 30.23%
⚠️ main/SB/Game/zNPCTypeBossSB2 - .text -815 bytes -> 4.20%
⚠️ main/SB/Game/zNPCTypeBossPlankton - .text -320 bytes -> 43.34%
⚠️ main/SB/Game/zNPCTypeBossPlankton - .text -51 bytes -> 68.85%
⚠️ main/SB/Game/zMain - zMainShowProgressBar() -36 bytes -> 85.94%
⚠️ main/SB/Game/zMain - zMainLoop() -100 bytes -> 61.14%
⚠️ main/SB/Game/zMain - zMainMemCardQueryPost(int, int, int, int) -36 bytes -> 72.50%
⚠️ main/SB/Game/zMain - zMainMemCardRenderText(const char*, bool) -12 bytes -> 92.11%
⚠️ main/SB/Game/zMain - zMainLoadFontHIP() -19 bytes -> 93.24%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_InitStacking(zScene*) -4 bytes -> 98.44%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_InitFX(zScene*) -469 bytes -> 30.52%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_PickTikisToAnimate() -4 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_Timestep(xScene*, float) -48 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_ReparentOrphans() -196 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::Reset() -32 bytes -> 92.45%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::Init(xEntAsset*) -336 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::SetCarryState(en_NPC_CARRY_STATE) -414 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::SelfSetup() -367 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::Process(xScene*, float) -140 bytes -> 24.03%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::SysEvent(xBase*, xBase*, unsigned int, const float*, xBase*, int*) -292 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::AddChild(zNPCTiki*) -64 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::RemoveChild(zNPCTiki*) -104 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::RemoveParent(zNPCTiki*) -144 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::ParentUpdated(zNPCTiki*) -68 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::RemoveFromFamily() -204 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - loveyFloat(zNPCTiki*, float) -176 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - loveyTikiRender(xEnt*) -400 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Intro::create(int, RyzMemGrow*, void*) -112 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Idle::create(int, RyzMemGrow*, void*) -112 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Taunt::create(int, RyzMemGrow*, void*) -112 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Dizzy::create(int, RyzMemGrow*, void*) -112 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Hit::create(int, RyzMemGrow*, void*) -112 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Hunt::create(int, RyzMemGrow*, void*) -112 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Swipe::create(int, RyzMemGrow*, void*) -112 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Swipe::Enter(float, void*) -200 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Chop::create(int, RyzMemGrow*, void*) -112 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Chop::Enter(float, void*) -212 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Karate::create(int, RyzMemGrow*, void*) -112 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Karate::Enter(float, void*) -32 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Death::create(int, RyzMemGrow*, void*) -112 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::location() const -16 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::get_home() const -12 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Intro::zNPCGoalBossSB2Intro(int, zNPCB_SB2&) -76 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Idle::zNPCGoalBossSB2Idle(int, zNPCB_SB2&) -76 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Taunt::zNPCGoalBossSB2Taunt(int, zNPCB_SB2&) -76 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Dizzy::zNPCGoalBossSB2Dizzy(int, zNPCB_SB2&) -76 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Hit::zNPCGoalBossSB2Hit(int, zNPCB_SB2&) -76 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Hunt::zNPCGoalBossSB2Hunt(int, zNPCB_SB2&) -76 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::start_location() const -12 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Swipe::zNPCGoalBossSB2Swipe(int, zNPCB_SB2&) -76 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Chop::zNPCGoalBossSB2Chop(int, zNPCB_SB2&) -76 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::facing() const -16 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Karate::zNPCGoalBossSB2Karate(int, zNPCB_SB2&) -76 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCGoalBossSB2Death::zNPCGoalBossSB2Death(int, zNPCB_SB2&) -76 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCGoalBPlanktonTaunt::Enter(float, void*) -32 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCGoalBPlanktonTaunt::Exit(float, void*) -32 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCGoalBPlanktonMove::Enter(float, void*) -32 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCGoalBPlanktonMove::Exit(float, void*) -32 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCGoalBPlanktonFall::Exit(float, void*) -32 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCGoalBPlanktonDizzy::Exit(float, void*) -32 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCGoalBPlanktonWall::Enter(float, void*) -32 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCGoalBPlanktonWall::Exit(float, void*) -32 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCGoalBPlanktonMissle::Enter(float, void*) -32 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCGoalBPlanktonMissle::Exit(float, void*) -32 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCBPlankton::location() const -16 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCBPlankton::enable_emitter(xParEmitter&) const -16 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCBPlankton::disable_emitter(xParEmitter&) const -4 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCBPlankton::ColPenByFlags() const -8 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossPlankton - zNPCBPlankton::PhysicsFlags() const -8 bytes -> 0.00%

Progress: 4

📈 main/SB/Core/x/xShadowSimple - .text +80 bytes -> 8.82%
📈 main/SB/Game/zNPCTypeBossPlankton - .data +112 bytes -> 71.77%
📈 main/SB/Core/x/xShadowSimple - .sdata2 +11 bytes -> 36.84%
📈 main/SB/Core/x/xShadowSimple - xShadowSimple_CacheInit(xShadowSimpleCache*, xEnt*, unsigned char) +80 bytes -> 22.73%

@daft7
Copy link
Contributor Author

daft7 commented Oct 10, 2025

Cleaned up a little bit but done for now.

@JoshSanch JoshSanch merged commit d5da6cb into bfbbdecomp:main Oct 10, 2025
5 checks passed
@daft7 daft7 deleted the DaftShadow branch October 10, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants