Skip to content

Cleaned Code, Implemented fixes#601

Merged
JoshSanch merged 16 commits intobfbbdecomp:mainfrom
LivewireCB:dev14
Oct 3, 2025
Merged

Cleaned Code, Implemented fixes#601
JoshSanch merged 16 commits intobfbbdecomp:mainfrom
LivewireCB:dev14

Conversation

@LivewireCB
Copy link
Contributor

Implemented and cleaned the dutchman code up.
Fixed xFX_SceneEnter
Other misc changes.

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

🆗 ✅

+1780 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

No Regressions 🎉

Progress: 21

📈 main/SB/Game/zNPCTypeDutchman - .text +1077 bytes -> 39.85%
📈 main/SB/Core/x/xFX - .text +371 bytes -> 24.59%
📈 main/SB/Game/zNPCTypePrawn - .text +140 bytes -> 13.42%
📈 main/SB/Game/zTalkBox - .text +19 bytes -> 12.09%
📈 main/SB/Game/zNPCTypeDutchman - .data +2 bytes -> 75.54%
📈 main/SB/Core/x/xFX - .rodata +170 bytes -> 82.96%
main/SB/Core/x/xFX - xFX_SceneEnter(RpWorld*) +364 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::update_fade(float) +356 bytes -> 93.68%
📈 main/SB/Core/x/xFX - xFXShinyRender(RpAtomic*) +8 bytes -> 70.00%
main/SB/Game/zNPCTypeDutchman - zNPCDutchman::coalesce(float) +284 bytes -> 100.00%
📈 main/SB/Game/zTalkBox - @unnamed@zTalkBox_cpp@::reset_auto_wait() +4 bytes -> 2.22%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::reset_blob_mat() +80 bytes -> 44.44%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::start_fight() +92 bytes -> 56.10%
📈 main/SB/Game/zNPCTypePrawn - @unnamed@zNPCTypePrawn_cpp@::kill_sound(int, unsigned int) +4 bytes -> 2.94%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::set_life(int) +85 bytes -> 62.86%
📈 main/SB/Game/zTalkBox - @unnamed@zTalkBox_cpp@::trigger(unsigned int) +11 bytes -> 36.36%
📈 main/SB/Game/zTalkBox - @unnamed@zTalkBox_cpp@::flush_triggered() +4 bytes -> 3.33%
main/SB/Game/zNPCTypeDutchman - zNPCDutchman::ParseINI() +104 bytes -> 100.00%
📈 main/SB/Game/zNPCTypePrawn - aqua_beam::kill_ring() +48 bytes -> 50.00%
main/SB/Game/zNPCTypePrawn - aqua_beam::update(float) +88 bytes -> 100.00%
main/SB/Game/zNPCTypeDutchman - zNPCDutchman::update_camera(float) +76 bytes -> 100.00%

@JoshSanch
Copy link
Collaborator

Good shtuff

@JoshSanch JoshSanch merged commit fe3235e into bfbbdecomp:main Oct 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants