Skip to content

zNPCDutchman work#598

Closed
LivewireCB wants to merge 20 commits intobfbbdecomp:mainfrom
LivewireCB:dev9
Closed

zNPCDutchman work#598
LivewireCB wants to merge 20 commits intobfbbdecomp:mainfrom
LivewireCB:dev9

Conversation

@LivewireCB
Copy link
Contributor

@LivewireCB LivewireCB commented Sep 23, 2025

Pretty much done with the file.

Creating new branch after this pr.

LivewireCB and others added 19 commits July 13, 2025 23:23
@LivewireCB
ported zNPCSupport code, zNPCTypeCommon
05655b7
@LivewireCB
build fix
17f6f58
@LivewireCB
Merge branch 'bfbbdecomp:main' into main
f0d3829
@LivewireCB
zNPCTypeBossPlankton & zNPCTypeBossSB2 work (bfbbdecomp#589)
328db99 
* ported zNPCSupport code, zNPCTypeCommon

* build fix

* BossSB2 & BossPlankton
@LivewireCB
zTalkbox, xScrFx & misc (bfbbdecomp#590)
193a788 
* ported zNPCSupport code, zNPCTypeCommon

* build fix

* BossSB2 & BossPlankton

* zTalkbox work and xScrFx

* Floating point error handler func
@SquareMan @LivewireCB
zAssetTypes done for now (bfbbdecomp#588)
4e22741 
* Progress

* zAssetTypes done for now

* Mark zAssetTypes equivalent
@LivewireCB
Merge branch 'bfbbdecomp:main' into main
8b39d69
@LivewireCB
Couple functions in zNPCMessenger. Misc fixes
8ee7ea7
@LivewireCB
build fix
fac342f
@LivewireCB
xFX work and misc
80dc53e
@LivewireCB
Dutchman + misc
3fcc5ef
@LivewireCB
Review Fixes
33ba5f1
@LivewireCB
ported zNPCSupport code, zNPCTypeCommon
4032c3a
@LivewireCB
Merge branch 'main' of https://github.com/LivewireCB/bfbb-decomp
1a5acf1
@LivewireCB
Merge branch 'bfbbdecomp:main' into main
9cb0374
@LivewireCB
Merge branch 'main' of https://github.com/bfbbdecomp/bfbb
55540d3
@LivewireCB
Merge branch 'main' of https://github.com/LivewireCB/bfbb-decomp
2fb01a6
@LivewireCB
Merge branch 'dev9' of https://github.com/LivewireCB/bfbb-decomp into…
b7c6d4e 
… dev9
@LivewireCB
zNPCTypeDutchman
f7ee5f2
@github-actions
Copy link

github-actions bot commented Sep 23, 2025

⚠️ 🔥

+1308 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

Regressions: 2

⚠️ main/SB/Game/zNPCTypeDutchman - .bss -455 bytes -> 87.97%
⚠️ main/SB/Game/zNPCTypeDutchman - @unnamed@zNPCTypeDutchman_cpp@::tweak_group::register_tweaks(bool, xModelAssetParam*, unsigned int, const char*) -224 bytes -> 89.68%

Progress: 23

📈 main/SB/Game/zNPCTypeDutchman - .text +1082 bytes -> 39.87%
📈 main/SB/Game/zNPCTypeDutchman - .data +4 bytes -> 75.76%
📈 main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::Enter(float, void*) +40 bytes -> 10.10%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::update_fade(float) +356 bytes -> 93.68%
✅ main/SB/Game/zNPCTypeDutchman - zNPCDutchman::coalesce(float) +284 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::dissolve(float) +8 bytes -> 92.42%
📈 main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanBeam::update_stop(float) +4 bytes -> 1.54%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::get_splash_loc() const +4 bytes -> 1.89%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::reset_blob_mat() +80 bytes -> 44.44%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::render_beam() +4 bytes -> 2.38%
📈 main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanIdle::Process(en_trantype*, float, void*, xScene*) +8 bytes -> 90.70%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::start_fight() +92 bytes -> 56.10%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::set_life(int) +85 bytes -> 62.86%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::LassoNotify(en_LASSO_EVENT) +76 bytes -> 89.29%
✅ main/SB/Game/zNPCTypeDutchman - zNPCDutchman::decompose() +12 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCDutchman::ParseINI() +104 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::next_goal() +4 bytes -> 3.85%
✅ main/SB/Game/zNPCTypeDutchman - zNPCDutchman::update_camera(float) +76 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - @unnamed@zNPCTypeDutchman_cpp@::set_volume(int, unsigned int, float) +28 bytes -> 53.33%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::get_eye_loc(int) const +12 bytes -> 20.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::get_hand_loc(int) const +4 bytes -> 6.67%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::Exit(float, void*) +19 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::goal_delay() +4 bytes -> 10.00%

JoshSanch
JoshSanch requested changes Sep 23, 2025
View reviewed changes
Copy link
Collaborator

@JoshSanch JoshSanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you investigate the register_tweaks regression? That seems like a real regression and it may be based on the struct changes.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

⚠️ 🔥

+1324 bytes
🆗 Bot Rating: A fantastic contribution! ✨🎉

Regressions: 21

⚠️ main/SB/Game/zNPCTypeCommon - .rodata -2 bytes -> 92.67%
⚠️ main/SB/Game/zNPCTypeAmbient - .sdata2 -19 bytes -> 34.48%
⚠️ main/SB/Game/zNPCTypeTiki - .bss -63 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - .sbss -4 bytes -> 40.00%
⚠️ main/SB/Game/zNPCTypeTiki - .sdata2 -99 bytes -> 7.84%
⚠️ main/SB/Game/zNPCTypeTiki - .text -1063 bytes -> 10.73%
⚠️ main/SB/Game/zNPCTypeTiki - .text -103 bytes -> 51.85%
⚠️ main/SB/Game/zNPCTypeBossSB2 - .data -2 bytes -> 74.07%
⚠️ main/SB/Game/zNPCTypeBossSB2 - .text -68 bytes -> 30.04%
⚠️ main/SB/Game/zNPCTypeBossSB2 - .text -23 bytes -> 2.40%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_InitFX(zScene*) -278 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki_ExplodeFX(zNPCTiki*) -4 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::Process(xScene*, float) -572 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - tikiDeadCB(xGoal*, void*, en_trantype*, float, void*) -36 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - genericTikiRender(xEnt*) -208 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::zNPCTiki(int) -60 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeTiki - zNPCTiki::AnimPick(int, en_NPC_GOAL_SPOT, xGoal*) -44 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - @unnamed@zNPCTypeBossSB2_cpp@::set_alpha_blend(xModelInstance*) -31 bytes -> 11.11%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::NewTime(xScene*, float) -4 bytes -> 0.00%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::abandon_slugs() -31 bytes -> 11.11%
⚠️ main/SB/Game/zNPCTypeBossSB2 - zNPCB_SB2::choose_hand() -23 bytes -> 53.85%

Progress: 27

📈 main/SB/Game/zNPCTypeDutchman - .text +1281 bytes -> 40.43%
📈 main/SB/Game/zNPCTypeDutchman - .data +4 bytes -> 75.76%
📈 main/SB/Game/zNPCTypeDutchman - .sdata2 +2 bytes -> 18.24%
✅ main/SB/Game/zNPCTypeTiki - zNPCTiki::Reset() +32 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::Enter(float, void*) +40 bytes -> 10.10%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::update_fade(float) +356 bytes -> 93.68%
✅ main/SB/Game/zNPCTypeDutchman - zNPCDutchman::coalesce(float) +284 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::dissolve(float) +8 bytes -> 92.42%
📈 main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanBeam::update_stop(float) +4 bytes -> 1.54%
✅ main/SB/Game/zNPCTypeTiki - zNPCTiki_InitStacking(zScene*) +4 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::get_splash_loc() const +4 bytes -> 1.89%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::reset_blob_mat() +80 bytes -> 44.44%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::render_beam() +4 bytes -> 2.38%
📈 main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanIdle::Process(en_trantype*, float, void*, xScene*) +8 bytes -> 90.70%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::start_fight() +92 bytes -> 56.10%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::set_life(int) +85 bytes -> 62.86%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::LassoNotify(en_LASSO_EVENT) +76 bytes -> 89.29%
✅ main/SB/Game/zNPCTypeDutchman - zNPCDutchman::decompose() +12 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCDutchman::ParseINI() +104 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::next_goal() +4 bytes -> 3.85%
✅ main/SB/Game/zNPCTypeDutchman - zNPCDutchman::update_camera(float) +76 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - @unnamed@zNPCTypeDutchman_cpp@::set_volume(int, unsigned int, float) +3 bytes -> 12.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::get_eye_loc(int) const +12 bytes -> 20.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::get_hand_loc(int) const +4 bytes -> 6.67%
✅ main/SB/Game/zNPCTypeCommon - zNPCCommon_SceneFinish() +3 bytes -> 100.00%
✅ main/SB/Game/zNPCTypeDutchman - zNPCGoalDutchmanInitiate::Exit(float, void*) +19 bytes -> 100.00%
📈 main/SB/Game/zNPCTypeDutchman - zNPCDutchman::goal_delay() +4 bytes -> 10.00%

@LivewireCB LivewireCB closed this Oct 3, 2025
@LivewireCB LivewireCB deleted the dev9 branch October 3, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshSanch JoshSanch JoshSanch requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LivewireCB @JoshSanch @SquareMan