ztalkbox::stop_wait 100%

[LSLees]

No description provided.

[github-actions]

⚠️ 🔥

+36 bytes
🆗 Bot Rating: A small contribution, every little bit helps!

Regressions: 23

⚠️ main/SB/Core/x/xGrid - .text -299 bytes -> 34.90%
⚠️ main/SB/Game/zGrid - .data -104 bytes -> 0.00%
⚠️ main/SB/Game/zGrid - .rodata -304 bytes -> 7.16%
⚠️ main/SB/Game/zGrid - .sbss -2 bytes -> 66.67%
⚠️ main/SB/Game/zGrid - .sdata2 -35 bytes -> 0.00%
⚠️ main/SB/Game/zGrid - .text -2088 bytes -> 2.77%
⚠️ main/SB/Core/gc/iTRC - .data -56 bytes -> 0.00%
⚠️ main/SB/Core/gc/iTRC - .rodata -649 bytes -> 0.92%
⚠️ main/SB/Core/gc/iTRC - .sdata2 -3 bytes -> 85.00%
⚠️ main/SB/Core/gc/iTRC - .text -816 bytes -> 73.06%
⚠️ main/SB/Core/x/xGrid - xGridInit(xGrid*, const xBox*, unsigned short, unsigned short, unsigned char) -299 bytes -> 0.00%
⚠️ main/SB/Game/zGrid - hack_flag_shadows(zScene*) -880 bytes -> 0.00%
⚠️ main/SB/Game/zGrid - zGridReset(zScene*) -228 bytes -> 0.00%
⚠️ main/SB/Game/zGrid - zGridInit(zScene*) -608 bytes -> 0.00%
⚠️ main/SB/Game/zGrid - zGridUpdateEnt(xEnt*) -372 bytes -> 0.00%
⚠️ main/SB/Core/gc/iTRC - ROMFont::Init() -24 bytes -> 73.91%
⚠️ main/SB/Core/gc/iTRC - ROMFont::DrawCell(int, int, int, int) -123 bytes -> 37.29%
⚠️ main/SB/Core/gc/iTRC - GXPosition3s16 -20 bytes -> 0.00%
⚠️ main/SB/Core/gc/iTRC - ROMFont::DrawTextBox(int, int, int, int, char*) -31 bytes -> 60.66%
⚠️ main/SB/Core/gc/iTRC - ResetButton::CheckResetButton() -143 bytes -> 30.77%
⚠️ main/SB/Core/gc/iTRC - iTRCDisk::DisplayErrorMessage() -64 bytes -> 63.64%
⚠️ main/SB/Core/gc/iTRC - iTRCDisk::SetDVDState() -212 bytes -> 1.85%
⚠️ main/SB/Core/gc/iTRC - iTRCDisk::CheckDVDAndResetState() -196 bytes -> 2.00%

Progress: 2

📈 main/SB/Game/zTalkBox - .text +36 bytes -> 11.94%
✅ main/SB/Game/zTalkBox - ztalkbox::stop_wait(unsigned int) +36 bytes -> 100.00%

[github-actions]

🆗 ✅

+36 bytes
🆗 Bot Rating: A small contribution, every little bit helps!

No Regressions 🎉

Progress: 2

📈 main/SB/Game/zTalkBox - .text +36 bytes -> 11.94%
✅ main/SB/Game/zTalkBox - ztalkbox::stop_wait(unsigned int) +36 bytes -> 100.00%

[tgsm]

Suggested change

	if (shared.active != this)
	{
	//shared.unk8D48 |= unk;
	return;
	}
	shared.wait_event_mask = shared.wait_event_mask | x;
	return;
	if (shared.active == this)
	{
	shared.wait_event_mask |= x;
	}

[SquareMan]

In addition to what tgsm has reviewed I would suggest setting up clang-format for your editor and having it run on file save. You have a lot of extra empty lines that would be removed by a formatting pass.

[github-actions]

🆗 ✅

+36 bytes
🆗 Bot Rating: A small contribution, every little bit helps!

No Regressions 🎉

Progress: 2

📈 main/SB/Game/zTalkBox - .text +36 bytes -> 11.94%
✅ main/SB/Game/zTalkBox - ztalkbox::stop_wait(unsigned int) +36 bytes -> 100.00%