Skip to content

zGrid 93%#593

Merged
SquareMan merged 8 commits intobfbbdecomp:mainfrom
bluisblu:main
Sep 4, 2025
Merged

zGrid 93%#593
SquareMan merged 8 commits intobfbbdecomp:mainfrom
bluisblu:main

Conversation

@bluisblu
Copy link
Contributor

@bluisblu bluisblu commented Sep 4, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

🆗 ✅

+2832 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 11

📈 main/SB/Core/x/xGrid - .text +299 bytes -> 43.29%
📈 main/SB/Game/zGrid - .text +2088 bytes -> 78.87%
main/SB/Game/zGrid - .rodata +304 bytes -> 100.00%
main/SB/Game/zGrid - .data +104 bytes -> 100.00%
📈 main/SB/Game/zGrid - .sdata2 +35 bytes -> 88.89%
main/SB/Game/zGrid - .sbss +2 bytes -> 100.00%
📈 main/SB/Game/zGrid - zGridInit(zScene*) +608 bytes -> 55.68%
📈 main/SB/Game/zGrid - hack_flag_shadows(zScene*) +880 bytes -> 95.67%
📈 main/SB/Game/zGrid - zGridUpdateEnt(xEnt*) +372 bytes -> 86.92%
📈 main/SB/Core/x/xGrid - xGridInit(xGrid*, const xBox*, unsigned short, unsigned short, unsigned char) +299 bytes -> 70.75%
main/SB/Game/zGrid - zGridReset(zScene*) +228 bytes -> 100.00%

Copy link
Member

@SquareMan SquareMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions are looking good but there's a few minor things that need addressing before merge.

Comment on lines +8 to +10
#include "xMath.h"

#include <PowerPC_EABI_Support\MSL_C\MSL_Common\cmath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I might be wrong so ignore this if it doesn't work but I"m pretty sure the cmath include should just be this:

Suggested change
#include "xMath.h"
#include <PowerPC_EABI_Support\MSL_C\MSL_Common\cmath>
#include "xMath.h"
#include <cmath>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, full path is necessary unfortunately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this may be a project configuration issue I should look into.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should still be moved to zGrid.cpp though

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

🆗 ✅

+2832 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 11

📈 main/SB/Core/x/xGrid - .text +299 bytes -> 43.29%
📈 main/SB/Game/zGrid - .text +2088 bytes -> 78.87%
main/SB/Game/zGrid - .rodata +304 bytes -> 100.00%
main/SB/Game/zGrid - .data +104 bytes -> 100.00%
📈 main/SB/Game/zGrid - .sdata2 +35 bytes -> 88.89%
main/SB/Game/zGrid - .sbss +2 bytes -> 100.00%
📈 main/SB/Game/zGrid - zGridInit(zScene*) +608 bytes -> 55.68%
📈 main/SB/Game/zGrid - hack_flag_shadows(zScene*) +880 bytes -> 95.67%
📈 main/SB/Game/zGrid - zGridUpdateEnt(xEnt*) +372 bytes -> 86.92%
📈 main/SB/Core/x/xGrid - xGridInit(xGrid*, const xBox*, unsigned short, unsigned short, unsigned char) +299 bytes -> 70.75%
main/SB/Game/zGrid - zGridReset(zScene*) +228 bytes -> 100.00%

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

🆗 ✅

+2832 bytes
🆗 Bot Rating: Amazing contribution, you are the decomp GOAT 🐐

No Regressions 🎉

Progress: 11

📈 main/SB/Core/x/xGrid - .text +299 bytes -> 43.29%
📈 main/SB/Game/zGrid - .text +2088 bytes -> 78.87%
main/SB/Game/zGrid - .rodata +304 bytes -> 100.00%
main/SB/Game/zGrid - .data +104 bytes -> 100.00%
📈 main/SB/Game/zGrid - .sdata2 +35 bytes -> 88.89%
main/SB/Game/zGrid - .sbss +2 bytes -> 100.00%
📈 main/SB/Game/zGrid - zGridInit(zScene*) +608 bytes -> 55.68%
📈 main/SB/Game/zGrid - hack_flag_shadows(zScene*) +880 bytes -> 95.67%
📈 main/SB/Game/zGrid - zGridUpdateEnt(xEnt*) +372 bytes -> 86.92%
📈 main/SB/Core/x/xGrid - xGridInit(xGrid*, const xBox*, unsigned short, unsigned short, unsigned char) +299 bytes -> 70.75%
main/SB/Game/zGrid - zGridReset(zScene*) +228 bytes -> 100.00%

@SquareMan SquareMan merged commit 722e4cc into bfbbdecomp:main Sep 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants