Skip to content

Remove xsqrt declaration from xBound.h#592

Merged
SquareMan merged 1 commit intomainfrom
xsqrt_fix
Sep 28, 2025
Merged

Remove xsqrt declaration from xBound.h#592
SquareMan merged 1 commit intomainfrom
xsqrt_fix

Conversation

@SquareMan
Copy link
Member

xsqrt shouldn't be declared in xBound.h

Also did a pass over all xBound.h includes to remove the ones that were only there for xsqrt

@SquareMan SquareMan requested a review from JoshSanch September 1, 2025 08:42
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

⚠️ 🔥

+0 bytes
🆗 Bot Rating: Zero progress? What are you up to? 👀

Regressions: 9

⚠️ main/SB/Game/zAssetTypes - .data -2 bytes -> 99.95%
⚠️ main/SB/Game/zAssetTypes - .rodata -5 bytes -> 98.88%
⚠️ main/SB/Game/zAssetTypes - .sbss -5 bytes -> 87.50%
⚠️ main/SB/Game/zAssetTypes - .sdata -8 bytes -> 12.50%
⚠️ main/SB/Game/zAssetTypes - .sdata2 -19 bytes -> 40.00%
⚠️ main/SB/Game/zAssetTypes - .text -1768 bytes -> 52.85%
⚠️ main/SB/Game/zAssetTypes - soundEffectCB(unsigned int, xAnimActiveEffect*, xAnimSingle*, void*) -536 bytes -> 0.00%
⚠️ main/SB/Game/zAssetTypes - FindAssetCB(unsigned int, char*) -36 bytes -> 0.00%
⚠️ main/SB/Game/zAssetTypes - ATBL_Read(void*, unsigned int, void*, unsigned int, unsigned int*) -1196 bytes -> 0.33%

No Progress

What is this PR doing? 🤔

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

🆗 ✅

+0 bytes
🆗 Bot Rating: Zero progress? What are you up to? 👀

No Regressions 🎉

No Progress

What is this PR doing? 🤔

@github-actions
Copy link

🆗 ✅

+0 bytes
🆗 Bot Rating: Zero progress? What are you up to? 👀

No Regressions 🎉

No Progress

What is this PR doing? 🤔

@SquareMan SquareMan merged commit a656586 into main Sep 28, 2025
10 checks passed
@SquareMan SquareMan deleted the xsqrt_fix branch September 28, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant