Conversation
🆗 ✅+68 bytes No Regressions 🎉Progress: 5📈 |
|
JoshSanch
left a comment
JoshSanch
left a comment
There was a problem hiding this comment.
Good work! Left some review comments
| RpLight* sEmptyDirectionalLight; | ||
| RpLight* sEmptyAmbientLight; |
There was a problem hiding this comment.
These need to be made static per objdiff.
| } | ||
|
|
||
|
|
||
| RpAtomic* NextAtomicCallback(RpAtomic* atomic, void* data) |
There was a problem hiding this comment.
This function should be static as per objdiff.
| for (S32 i = 0; i < 4; i++) | ||
| { | ||
| frame = (RwFrame*)RpLightCreate(i); | ||
| //black = frame; |
There was a problem hiding this comment.
Please remember to take out commented code - it adds unnecessary noise when trying to debug functions to increase the match.
| } | ||
| else | ||
| { | ||
| //modelArray[0] = (S32)model; |
There was a problem hiding this comment.
Please remember to take out commented code - it adds unnecessary noise when trying to debug functions to increase the match.
| // What? | ||
|
|
There was a problem hiding this comment.
Could you clarify this comment? Is there something here that you felt might be particularly confusing for future contributors?
2 participants
Not proud of the work done here so far. It's a lot of guessing even with the dwarf data
TLDR; Skill issue