SDK Merge by LivewireCB · Pull Request #570 · bfbbdecomp/bfbb

LivewireCB · 2025-05-25T00:33:01Z

All Dolphin SDK files are added and building. With the majority of them being close to Matching.

5/24/25
84.38% Matched
24.90% linked

… dev5

github-actions · 2025-05-25T00:43:12Z

⚠️ 🔥

+434 bytes
🆗 Bot Rating: A decent contribution. Thank you!

Regressions: 23

⚠️ main/SB/Core/x/xAnim - .text -71 bytes -> 92.11%
⚠️ main/SB/Core/gc/iMix - .text -1827 bytes -> 7.94%
⚠️ main/SB/Core/gc/ngcrad3d - .sdata2 -30 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - .text -272 bytes -> 13.38%
⚠️ main/SB/Core/gc/iTRC - .text -19 bytes -> 73.06%
⚠️ main/SB/Core/x/xAnim - std::atan2f(float, float) -36 bytes -> 0.00%
⚠️ main/SB/Core/x/xAnim - std::floorf(float) -36 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXInit -100 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXInitChannel -1788 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXReleaseChannel -28 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXAdjustInput -48 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXGetInput -28 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXAdjustPan -92 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXGetPan -28 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXAdjustFader -48 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXGetFader -28 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Open_RAD_3D_image -232 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Unlock_RAD_3D_image -48 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXEnd -4 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXTexCoord2f32 -16 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXColor4u8 -24 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXPosition3s16 -20 bytes -> 0.00%
⚠️ main/SB/Core/gc/iTRC - GXPosition3s16 -20 bytes -> 0.00%

Progress: 6

📈 main/SB/Game/zNPCTypeBossPlankton - .rodata +2 bytes -> 77.64%
📈 main/SB/Core/gc/iMix - __MIXSetPan(MIXChannel*) +140 bytes -> 83.72%
✅ main/SB/Core/gc/iMix - __MIXResetChannel(MIXChannel*) +120 bytes -> 100.00%
📈 main/SB/Core/gc/ngcrad3d - Setup_surface_array() +72 bytes -> 64.29%
✅ main/SB/Core/gc/iMix - __MIXGetVolume(int) +60 bytes -> 100.00%
✅ main/SB/Core/gc/iMix - __MIXClampPan(int) +40 bytes -> 100.00%

github-actions · 2025-05-25T00:53:13Z

⚠️ 🔥

+434 bytes
🆗 Bot Rating: A decent contribution. Thank you!

Regressions: 23

⚠️ main/SB/Core/x/xAnim - .text -71 bytes -> 92.11%
⚠️ main/SB/Core/gc/iMix - .text -1827 bytes -> 7.94%
⚠️ main/SB/Core/gc/ngcrad3d - .sdata2 -30 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - .text -272 bytes -> 13.38%
⚠️ main/SB/Core/gc/iTRC - .text -19 bytes -> 73.06%
⚠️ main/SB/Core/x/xAnim - std::atan2f(float, float) -36 bytes -> 0.00%
⚠️ main/SB/Core/x/xAnim - std::floorf(float) -36 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXInit -100 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXInitChannel -1788 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXReleaseChannel -28 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXAdjustInput -48 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXGetInput -28 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXAdjustPan -92 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXGetPan -28 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXAdjustFader -48 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXGetFader -28 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Open_RAD_3D_image -232 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Unlock_RAD_3D_image -48 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXEnd -4 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXTexCoord2f32 -16 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXColor4u8 -24 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXPosition3s16 -20 bytes -> 0.00%
⚠️ main/SB/Core/gc/iTRC - GXPosition3s16 -20 bytes -> 0.00%

Progress: 6

📈 main/SB/Game/zNPCTypeBossPlankton - .rodata +2 bytes -> 77.64%
📈 main/SB/Core/gc/iMix - __MIXSetPan(MIXChannel*) +140 bytes -> 83.72%
✅ main/SB/Core/gc/iMix - __MIXResetChannel(MIXChannel*) +120 bytes -> 100.00%
📈 main/SB/Core/gc/ngcrad3d - Setup_surface_array() +72 bytes -> 64.29%
✅ main/SB/Core/gc/iMix - __MIXGetVolume(int) +60 bytes -> 100.00%
✅ main/SB/Core/gc/iMix - __MIXClampPan(int) +40 bytes -> 100.00%

JoshSanch

Absolutely fantastic work. This wasn't strictly necessary for the project to be considered a success in the long-term but having a comprehensive decompilation of the game and all of its dependencies is a worthy goal.

Some discussion questions for follow-up for documentation purposes - I mentioned in the Discord but there are some project structure issues that I've determined as out-of-scope for this PR related to our include and the introduced libs folders, but that work does not need to block this PR.

config/GQPE78/splits.txt

config/GQPE78/symbols.txt

configure.py

github-actions · 2025-05-25T01:53:48Z

⚠️ 🔥

+434 bytes
🆗 Bot Rating: A decent contribution. Thank you!

Regressions: 23

⚠️ main/SB/Core/x/xAnim - .text -71 bytes -> 92.11%
⚠️ main/SB/Core/gc/iMix - .text -1827 bytes -> 7.94%
⚠️ main/SB/Core/gc/ngcrad3d - .sdata2 -30 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - .text -272 bytes -> 13.38%
⚠️ main/SB/Core/gc/iTRC - .text -19 bytes -> 73.06%
⚠️ main/SB/Core/x/xAnim - std::atan2f(float, float) -36 bytes -> 0.00%
⚠️ main/SB/Core/x/xAnim - std::floorf(float) -36 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXInit -100 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXInitChannel -1788 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXReleaseChannel -28 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXAdjustInput -48 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXGetInput -28 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXAdjustPan -92 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXGetPan -28 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXAdjustFader -48 bytes -> 0.00%
⚠️ main/SB/Core/gc/iMix - MIXGetFader -28 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Open_RAD_3D_image -232 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - Unlock_RAD_3D_image -48 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXEnd -4 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXTexCoord2f32 -16 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXColor4u8 -24 bytes -> 0.00%
⚠️ main/SB/Core/gc/ngcrad3d - GXPosition3s16 -20 bytes -> 0.00%
⚠️ main/SB/Core/gc/iTRC - GXPosition3s16 -20 bytes -> 0.00%

Progress: 6

📈 main/SB/Game/zNPCTypeBossPlankton - .rodata +2 bytes -> 77.64%
📈 main/SB/Core/gc/iMix - __MIXSetPan(MIXChannel*) +140 bytes -> 83.72%
✅ main/SB/Core/gc/iMix - __MIXResetChannel(MIXChannel*) +120 bytes -> 100.00%
📈 main/SB/Core/gc/ngcrad3d - Setup_surface_array() +72 bytes -> 64.29%
✅ main/SB/Core/gc/iMix - __MIXGetVolume(int) +60 bytes -> 100.00%
✅ main/SB/Core/gc/iMix - __MIXClampPan(int) +40 bytes -> 100.00%

JoshSanch · 2025-05-25T01:57:24Z

Note on regressions: Implemented code in ngcrad3d was straight up incorrect and did not match SDK definitions, so regressions are expected but also just the realization of those issues. For that reason, I am merging anyway.

LivewireCB added 12 commits May 20, 2025 22:43

zMain work

3166a81

merge cus lazy

6700176

review fixes

bd8b013

review fix 2

481c2b9

Day 1 SDK link

c538bda

Merge branch 'dev5' of https://github.com/LivewireCB/bfbb-decomp into…

0859258

… dev5

Finished adding in the last files for the SDK. All files are added.

510456a

Day 1 SDK link

9a30094

Finished adding in the last files for the SDK. All files are added.

e9fe72b

Merge branch 'dev5' of https://github.com/LivewireCB/bfbb-decomp into…

3aee8e0

… dev5

fixed a rebase issue and file cleanup

b7afd59

temp fix for ok bot

d0d1d14

Seperated bink from the dolphin SDK

9157ffb

JoshSanch reviewed May 25, 2025

View reviewed changes

config/GQPE78/splits.txt Show resolved Hide resolved

config/GQPE78/symbols.txt Show resolved Hide resolved

configure.py Show resolved Hide resolved

configure.py Show resolved Hide resolved

Fixed the commented code

87115f7

JoshSanch merged commit 82e1d6e into bfbbdecomp:main May 25, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDK Merge#570

SDK Merge#570
JoshSanch merged 14 commits intobfbbdecomp:mainfrom
LivewireCB:dev5

LivewireCB commented May 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 25, 2025

Uh oh!

github-actions bot commented May 25, 2025

Uh oh!

JoshSanch left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 25, 2025

Uh oh!

JoshSanch commented May 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LivewireCB commented May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 25, 2025

⚠️ 🔥

Regressions: 23

Progress: 6

Uh oh!

github-actions bot commented May 25, 2025

⚠️ 🔥

Regressions: 23

Progress: 6

Uh oh!

JoshSanch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 25, 2025

⚠️ 🔥

Regressions: 23

Progress: 6

Uh oh!

JoshSanch commented May 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LivewireCB commented May 25, 2025 •

edited

Loading