Skip to content

zNPCTypeBossPlankton, zNPCTypeBossSB2, zNPCTypeDutchman: register_tweaks work#568

Merged
JoshSanch merged 1 commit intobfbbdecomp:mainfrom
energydrink02:register_tweaks
May 23, 2025
Merged

zNPCTypeBossPlankton, zNPCTypeBossSB2, zNPCTypeDutchman: register_tweaks work#568
JoshSanch merged 1 commit intobfbbdecomp:mainfrom
energydrink02:register_tweaks

Conversation

@energydrink02
Copy link
Contributor

Add remaining register_tweaks functions in npc boss files

@github-actions
Copy link

🆗 ✅

+27944 bytes
🆗 Bot Rating: If I could feel emotions, I would be crying tears of joy right now.

No Regressions 🎉

Progress: 17

📈 main/SB/Game/zNPCTypeBossSB2 - .text +6515 bytes -> 29.74%
📈 main/SB/Game/zNPCTypeDutchman - .text +6448 bytes -> 32.86%
📈 main/SB/Game/zNPCTypeBossPlankton - .text +5360 bytes -> 36.35%
📈 main/SB/Game/zNPCTypeBossSB2 - .rodata +2955 bytes -> 54.78%
📈 main/SB/Game/zNPCTypeBossPlankton - .rodata +2863 bytes -> 77.24%
📈 main/SB/Game/zNPCTypeDutchman - .rodata +2538 bytes -> 72.04%
📈 main/SB/Game/zNPCTypeBossSB2 - .bss +618 bytes -> 44.44%
📈 main/SB/Game/zNPCTypeBossPlankton - .bss +342 bytes -> 25.00%
📈 main/SB/Game/zNPCTypeDutchman - .sdata2 +47 bytes -> 17.00%
📈 main/SB/Game/zNPCTypeBossSB2 - .sdata2 +132 bytes -> 62.50%
📈 main/SB/Game/zNPCTypeBossPlankton - .sdata2 +126 bytes -> 67.35%
📈 main/SB/Game/zNPCTypeBossSB2 - @unnamed@zNPCTypeBossSB2_cpp@::tweak_group::register_tweaks(bool, xModelAssetParam*, unsigned int, const char*) +6508 bytes -> 90.34%
📈 main/SB/Game/zNPCTypeDutchman - @unnamed@zNPCTypeDutchman_cpp@::tweak_group::register_tweaks(bool, xModelAssetParam*, unsigned int, const char*) +6444 bytes -> 92.91%
📈 main/SB/Game/zNPCTypeBossPlankton - @unnamed@zNPCTypeBossPlankton_cpp@::tweak_group::register_tweaks(bool, xModelAssetParam*, unsigned int, const char*) +5352 bytes -> 90.65%
📈 main/SB/Game/zNPCTypeBossSB2 - ZNPC_AnimTable_BossSB2() +7 bytes -> 56.38%
📈 main/SB/Game/zNPCTypeBossPlankton - ZNPC_AnimTable_BossPlankton() +8 bytes -> 79.61%
📈 main/SB/Game/zNPCTypeDutchman - ZNPC_AnimTable_Dutchman() +4 bytes -> 99.76%

Copy link
Collaborator

@JoshSanch JoshSanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Per Discord discussion, I share your concern around having to redefine auto_tweak in a bunch of places, but that's out of scope for this PR. Once this goes in, I'll explore some possibilities to reduce the redundancies there.

@JoshSanch JoshSanch merged commit d6d10e7 into bfbbdecomp:main May 23, 2025
5 checks passed
@energydrink02 energydrink02 deleted the register_tweaks branch May 23, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants